Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2202783002: android_webview: Remove unneeded RegisterNatives() calls (Closed)

Created:
4 years, 4 months ago by no sievers
Modified:
4 years, 4 months ago
Reviewers:
Torne
CC:
chromium-reviews, Dirk Pranke, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@jnireg1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android_webview: Remove unneeded RegisterNatives() calls BUG=603936 Committed: https://crrev.com/84125f76d3b33732d018db2b86f5fd91174330b7 Cr-Commit-Position: refs/heads/master@{#409247}

Patch Set 1 #

Patch Set 2 : android_webview: Remove unneeded RegisterNatives() calls #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -82 lines) Patch
M android_webview/native/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/native/android_webview_jni_registrar.cc View 1 4 chunks +0 lines, -15 lines 0 comments Download
M android_webview/native/aw_contents_background_thread_client.h View 1 chunk +0 lines, -3 lines 0 comments Download
M android_webview/native/aw_contents_background_thread_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M android_webview/native/aw_contents_client_bridge_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/native/aw_contents_io_thread_client_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M android_webview/native/aw_contents_io_thread_client_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M android_webview/native/aw_contents_lifecycle_notifier.h View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/native/aw_contents_lifecycle_notifier.cc View 1 chunk +0 lines, -4 lines 0 comments Download
D android_webview/native/aw_resource.h View 1 chunk +0 lines, -20 lines 0 comments Download
M android_webview/native/aw_resource.cc View 2 chunks +1 line, -5 lines 0 comments Download
M android_webview/native/aw_web_resource_response_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/native/aw_web_resource_response_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M android_webview/native/input_stream_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/native/input_stream_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M android_webview/native/input_stream_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/native/java_browser_view_renderer_helper.h View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/native/java_browser_view_renderer_helper.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M android_webview/native/webview_native.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (13 generated)
Torne
lgtm
4 years, 4 months ago (2016-08-02 12:24:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202783002/20001
4 years, 4 months ago (2016-08-02 18:11:45 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-02 18:18:03 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 18:20:34 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/84125f76d3b33732d018db2b86f5fd91174330b7
Cr-Commit-Position: refs/heads/master@{#409247}

Powered by Google App Engine
This is Rietveld 408576698