Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2199913003: media: Remove unneeded RegisterNatives() call (Closed)

Created:
4 years, 4 months ago by no sievers
Modified:
4 years, 4 months ago
Reviewers:
watk
CC:
chromium-reviews, toyoshim+midi_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, mlamouri+watch-media_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@jnireg1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Remove unneeded RegisterNatives() call BUG=603936 Committed: https://crrev.com/8699a9de980b74681697b8d8eabe1b050f6b1978 Cr-Commit-Position: refs/heads/master@{#409283}

Patch Set 1 #

Total comments: 9

Patch Set 2 : remove unused includes #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -53 lines) Patch
M media/base/android/media_codec_util.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/base/android/media_codec_util.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M media/base/android/media_jni_registrar.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
M media/base/android/sdk_media_codec_bridge.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/base/android/sdk_media_codec_bridge.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M media/capture/video/android/capture_jni_registrar.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M media/capture/video/android/photo_capabilities.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/capture/video/android/photo_capabilities.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M media/capture/video/android/video_capture_device_factory_android.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M media/capture/video/android/video_capture_device_factory_android.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M media/midi/midi_device_android.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/midi/midi_device_android.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M media/midi/midi_jni_registrar.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M media/midi/midi_output_port_android.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/midi/midi_output_port_android.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
no sievers
watk@ ptal! see patchset dependency and bug for more info
4 years, 4 months ago (2016-08-01 22:20:41 UTC) #3
watk
cool, lgtm https://codereview.chromium.org/2199913003/diff/1/media/base/android/media_jni_registrar.cc File media/base/android/media_jni_registrar.cc (right): https://codereview.chromium.org/2199913003/diff/1/media/base/android/media_jni_registrar.cc#newcode13 media/base/android/media_jni_registrar.cc:13: #include "media/base/android/media_codec_util.h" delete? https://codereview.chromium.org/2199913003/diff/1/media/base/android/media_jni_registrar.cc#newcode17 media/base/android/media_jni_registrar.cc:17: #include "media/base/android/sdk_media_codec_bridge.h" ...
4 years, 4 months ago (2016-08-01 23:59:41 UTC) #8
no sievers
thanks! https://codereview.chromium.org/2199913003/diff/1/media/base/android/media_jni_registrar.cc File media/base/android/media_jni_registrar.cc (right): https://codereview.chromium.org/2199913003/diff/1/media/base/android/media_jni_registrar.cc#newcode13 media/base/android/media_jni_registrar.cc:13: #include "media/base/android/media_codec_util.h" On 2016/08/01 23:59:40, watk wrote: > ...
4 years, 4 months ago (2016-08-02 00:03:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2199913003/40001
4 years, 4 months ago (2016-08-02 19:47:17 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-02 19:52:30 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 19:54:19 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8699a9de980b74681697b8d8eabe1b050f6b1978
Cr-Commit-Position: refs/heads/master@{#409283}

Powered by Google App Engine
This is Rietveld 408576698