Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2199943004: [DevTools] Rename V8Debugger to V8Inspector. (Closed)

Created:
4 years, 4 months ago by dgozman
Modified:
4 years, 4 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, Dirk Pranke, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, kinuko+watch, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Rename V8Debugger to V8Inspector. BUG=631162 Committed: https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082 Cr-Commit-Position: refs/heads/master@{#409131}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+568 lines, -2054 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.h View 6 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp View 5 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h View 4 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp View 18 chunks +33 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InspectedContext.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp View 10 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp View 7 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h View 4 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 37 chunks +64 lines, -64 lines 0 comments Download
D third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h View 1 chunk +0 lines, -209 lines 0 comments Download
D third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp View 1 chunk +0 lines, -1135 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp View 7 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp View 5 chunks +12 lines, -12 lines 0 comments Download
A + third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h View 6 chunks +10 lines, -12 lines 0 comments Download
A + third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.cpp View 56 chunks +90 lines, -90 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp View 12 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Regex.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp View 26 chunks +40 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.h View 4 chunks +9 lines, -9 lines 0 comments Download
A third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.cpp View 1 chunk +74 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h View 1 chunk +0 lines, -56 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h View 2 chunks +40 lines, -60 lines 0 comments Download
D third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.cpp View 1 chunk +0 lines, -74 lines 0 comments Download
A + third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorClient.h View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 2205913002 Patch 1
Issue 2205913002 Patch 20001

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please.
4 years, 4 months ago (2016-08-02 01:47:14 UTC) #2
pfeldman
lgtm
4 years, 4 months ago (2016-08-02 01:53:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2199943004/1
4 years, 4 months ago (2016-08-02 02:11:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 03:20:13 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 03:22:47 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082
Cr-Commit-Position: refs/heads/master@{#409131}

Powered by Google App Engine
This is Rietveld 408576698