Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp

Issue 2199943004: [DevTools] Rename V8Debugger to V8Inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp
index f5852b308cdb0ec4507dfacceecd09970fcd045f..04a0cb89fc293166f449ed8f81c4902d1579b28c 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp
@@ -32,16 +32,16 @@
#include "platform/inspector_protocol/Platform.h"
#include "platform/v8_inspector/V8Compat.h"
-#include "platform/v8_inspector/V8DebuggerImpl.h"
+#include "platform/v8_inspector/V8InspectorImpl.h"
#include "platform/v8_inspector/V8StringUtil.h"
-#include "platform/v8_inspector/public/V8DebuggerClient.h"
+#include "platform/v8_inspector/public/V8InspectorClient.h"
#include <v8.h>
namespace blink {
-V8FunctionCall::V8FunctionCall(V8DebuggerImpl* debugger, v8::Local<v8::Context> context, v8::Local<v8::Value> value, const String16& name)
- : m_debugger(debugger)
+V8FunctionCall::V8FunctionCall(V8InspectorImpl* inspector, v8::Local<v8::Context> context, v8::Local<v8::Value> value, const String16& name)
+ : m_inspector(inspector)
, m_context(context)
, m_name(toV8String(context->GetIsolate(), name))
, m_value(value)
@@ -81,7 +81,7 @@ v8::Local<v8::Value> V8FunctionCall::call(bool& hadException, bool reportExcepti
v8::Local<v8::Value> V8FunctionCall::callWithoutExceptionHandling()
{
// TODO(dgozman): get rid of this check.
- if (!m_debugger->client()->isExecutionAllowed())
+ if (!m_inspector->client()->isExecutionAllowed())
return v8::Local<v8::Value>();
v8::Local<v8::Object> thisObject = v8::Local<v8::Object>::Cast(m_value);
@@ -98,13 +98,13 @@ v8::Local<v8::Value> V8FunctionCall::callWithoutExceptionHandling()
DCHECK(!info[i].IsEmpty());
}
- int contextGroupId = V8DebuggerImpl::getGroupId(m_context);
+ int contextGroupId = V8InspectorImpl::getGroupId(m_context);
if (contextGroupId)
- m_debugger->client()->muteWarningsAndDeprecations(contextGroupId);
+ m_inspector->client()->muteWarningsAndDeprecations(contextGroupId);
v8::MicrotasksScope microtasksScope(m_context->GetIsolate(), v8::MicrotasksScope::kDoNotRunMicrotasks);
v8::MaybeLocal<v8::Value> maybeResult = function->Call(m_context, thisObject, m_arguments.size(), info.get());
if (contextGroupId)
- m_debugger->client()->unmuteWarningsAndDeprecations(contextGroupId);
+ m_inspector->client()->unmuteWarningsAndDeprecations(contextGroupId);
v8::Local<v8::Value> result;
if (!maybeResult.ToLocal(&result))

Powered by Google App Engine
This is Rietveld 408576698