Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2194893003: Remove NOTREACHED that gets hit for non well formed xhtml. (Closed)

Created:
4 years, 4 months ago by Bryan McQuade
Modified:
4 years, 4 months ago
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove NOTREACHED that gets hit for non well formed xhtml. BUG=627607 Committed: https://crrev.com/e0c18ae2e00183aaad8daaec74dd2e2ca869f673 Cr-Commit-Position: refs/heads/master@{#408766}

Patch Set 1 #

Patch Set 2 : add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M chrome/browser/page_load_metrics/metrics_web_contents_observer.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc View 1 2 chunks +20 lines, -0 lines 0 comments Download
A chrome/test/data/page_load_metrics/badxml.xhtml View 1 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/test/data/page_load_metrics/badxml.xhtml.mock-http-headers View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
Bryan McQuade
PTAL
4 years, 4 months ago (2016-07-29 20:10:32 UTC) #4
Charlie Harrison
Thank you for the change. Do you mind adding a browser test where we just ...
4 years, 4 months ago (2016-07-29 20:12:06 UTC) #6
Bryan McQuade
On 2016/07/29 at 20:12:06, csharrison wrote: > Thank you for the change. Do you mind ...
4 years, 4 months ago (2016-07-29 20:15:11 UTC) #8
inferno
lgtm
4 years, 4 months ago (2016-07-29 20:15:36 UTC) #10
Bryan McQuade
On 2016/07/29 at 20:15:11, Bryan McQuade wrote: > On 2016/07/29 at 20:12:06, csharrison wrote: > ...
4 years, 4 months ago (2016-07-29 20:35:00 UTC) #12
Charlie Harrison
lgtm thank you.
4 years, 4 months ago (2016-07-29 20:38:43 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194893003/20001
4 years, 4 months ago (2016-07-29 20:40:02 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 21:26:17 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 21:29:14 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e0c18ae2e00183aaad8daaec74dd2e2ca869f673
Cr-Commit-Position: refs/heads/master@{#408766}

Powered by Google App Engine
This is Rietveld 408576698