Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6445)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2194893003: Remove NOTREACHED that gets hit for non well formed xhtml. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
index ddd6cb8957531a8b6c00a4f6c600fb4849e6b2ff..a0ec8f19b63a1a28b4b54b7c42bd2fb45a997ea4 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
+++ b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
@@ -4,6 +4,7 @@
#include "base/macros.h"
#include "base/test/histogram_tester.h"
+#include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h"
#include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h"
#include "chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h"
#include "chrome/common/url_constants.h"
@@ -221,3 +222,22 @@ IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
histogram_tester_.ExpectTotalCount(
internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0);
}
+
+IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, BadXhtml) {
+ ASSERT_TRUE(embedded_test_server()->Start());
+
+ // When an XHTML page contains invalid XML, it causes a paint of the error
+ // message without a layout. Page load metrics currently treats this as an
+ // error. Eventually, we'll fix this by special casing the handling of
+ // documents with non-well-formed XML on the blink side. See crbug.com/627607
+ // for more.
+ ui_test_utils::NavigateToURL(
+ browser(),
+ embedded_test_server()->GetURL("/page_load_metrics/badxml.xhtml"));
+ NavigateToUntrackedUrl();
+
+ histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 0);
+ histogram_tester_.ExpectTotalCount(internal::kHistogramFirstPaint, 0);
+ histogram_tester_.ExpectBucketCount(page_load_metrics::internal::kErrorEvents,
+ page_load_metrics::ERR_BAD_TIMING_IPC, 1);
+}

Powered by Google App Engine
This is Rietveld 408576698