chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h - Issue 2194893003: Remove NOTREACHED that gets hit for non well formed xhtml.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

Issue 2194893003: Remove NOTREACHED that gets hit for non well formed xhtml. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/metrics_web_contents_observer.cc ('k') | chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

index 6e12687d87c4c20aa15696a40ba4688fab32354c..b33bc56863e80e98d66acc8ca3eb944307d07ceb 100644

--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

@@ -15,6 +15,7 @@ namespace internal {

// navigation start to the event in question.

extern const char kHistogramCommit[];

extern const char kHistogramFirstLayout[];

+extern const char kHistogramFirstPaint[];

extern const char kHistogramFirstTextPaint[];

extern const char kHistogramDomContentLoaded[];

extern const char kHistogramLoad[];