Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

Issue 2194893003: Remove NOTREACHED that gets hit for non well formed xhtml. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
index 4f1635151f42b52ef3e52a75ff967db51a72ba94..b8b781541f2b0d7d2a956496400dc1c665ab3671 100644
--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
@@ -156,8 +156,10 @@ bool IsValidPageLoadTiming(const PageLoadTiming& timing) {
}
if (!EventsInOrder(timing.first_layout, timing.first_paint)) {
- NOTREACHED() << "Invalid first_layout " << timing.first_layout
- << " for first_paint " << timing.first_paint;
+ // This can happen when we process an XHTML document that doesn't contain
+ // well formed XML. See crbug.com/627607.
+ DLOG(ERROR) << "Invalid first_layout " << timing.first_layout
+ << " for first_paint " << timing.first_paint;
return false;
}
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698