OLD | NEW |
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "base/macros.h" | 5 #include "base/macros.h" |
6 #include "base/test/histogram_tester.h" | 6 #include "base/test/histogram_tester.h" |
| 7 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h" |
7 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse
rver.h" | 8 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse
rver.h" |
8 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me
trics_observer.h" | 9 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me
trics_observer.h" |
9 #include "chrome/common/url_constants.h" | 10 #include "chrome/common/url_constants.h" |
10 #include "chrome/test/base/in_process_browser_test.h" | 11 #include "chrome/test/base/in_process_browser_test.h" |
11 #include "chrome/test/base/ui_test_utils.h" | 12 #include "chrome/test/base/ui_test_utils.h" |
12 #include "net/test/embedded_test_server/embedded_test_server.h" | 13 #include "net/test/embedded_test_server/embedded_test_server.h" |
13 | 14 |
14 class MetricsWebContentsObserverBrowserTest : public InProcessBrowserTest { | 15 class MetricsWebContentsObserverBrowserTest : public InProcessBrowserTest { |
15 public: | 16 public: |
16 MetricsWebContentsObserverBrowserTest() {} | 17 MetricsWebContentsObserverBrowserTest() {} |
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
214 ASSERT_TRUE(embedded_test_server()->Start()); | 215 ASSERT_TRUE(embedded_test_server()->Start()); |
215 | 216 |
216 ui_test_utils::NavigateToURL( | 217 ui_test_utils::NavigateToURL( |
217 browser(), embedded_test_server()->GetURL( | 218 browser(), embedded_test_server()->GetURL( |
218 "/page_load_metrics/document_write_no_script.html")); | 219 "/page_load_metrics/document_write_no_script.html")); |
219 NavigateToUntrackedUrl(); | 220 NavigateToUntrackedUrl(); |
220 | 221 |
221 histogram_tester_.ExpectTotalCount( | 222 histogram_tester_.ExpectTotalCount( |
222 internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0); | 223 internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0); |
223 } | 224 } |
| 225 |
| 226 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, BadXhtml) { |
| 227 ASSERT_TRUE(embedded_test_server()->Start()); |
| 228 |
| 229 // When an XHTML page contains invalid XML, it causes a paint of the error |
| 230 // message without a layout. Page load metrics currently treats this as an |
| 231 // error. Eventually, we'll fix this by special casing the handling of |
| 232 // documents with non-well-formed XML on the blink side. See crbug.com/627607 |
| 233 // for more. |
| 234 ui_test_utils::NavigateToURL( |
| 235 browser(), |
| 236 embedded_test_server()->GetURL("/page_load_metrics/badxml.xhtml")); |
| 237 NavigateToUntrackedUrl(); |
| 238 |
| 239 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 0); |
| 240 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstPaint, 0); |
| 241 histogram_tester_.ExpectBucketCount(page_load_metrics::internal::kErrorEvents, |
| 242 page_load_metrics::ERR_BAD_TIMING_IPC, 1); |
| 243 } |
OLD | NEW |