Chooser spinner should disappear as soon as one device shows up

Chooser spinner should disappear as soon as one device shows up

The chooser needs to show devices as they come. So the spinner should
disappear as soon as one device shows up. This can reduce the wait time
and user can select a device more quickly if it is already listed in
the chooser.

I added some screenshots at issue 583452.

BUG=583452, 632173
Committed: https://crrev.com/3fa2f4f2fe52f652837a96928cf525d4081004ad
Cr-Commit-Position: refs/heads/master@{#408687}

[juncai, 2016-07-28 19:05:22]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 19:06:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 20:13:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 20:13:02]

Dry run: This issue passed the CQ dry run.

[juncai, 2016-07-28 20:17:49]

Description was changed from

==========
Chooser spinner should disappear as soon as one device shows up

The chooser needs to show devices as they come. So the spinner should
disappear as soon as one device shows up. This can reduce the wait time
and user can select a device more quickly if it is already listed in
the chooser.

BUG=632173, 583452
==========

to

==========
Chooser spinner should disappear as soon as one device shows up

The chooser needs to show devices as they come. So the spinner should
disappear as soon as one device shows up. This can reduce the wait time
and user can select a device more quickly if it is already listed in
the chooser.

BUG=583452, 632173
==========

[juncai, 2016-07-28 20:26:20]

Description was changed from

==========
Chooser spinner should disappear as soon as one device shows up

The chooser needs to show devices as they come. So the spinner should
disappear as soon as one device shows up. This can reduce the wait time
and user can select a device more quickly if it is already listed in
the chooser.

BUG=583452, 632173
==========

to

==========
Chooser spinner should disappear as soon as one device shows up

The chooser needs to show devices as they come. So the spinner should
disappear as soon as one device shows up. This can reduce the wait time
and user can select a device more quickly if it is already listed in
the chooser.

I added some screenshots at issue 583452 page.

BUG=583452, 632173
==========

[juncai, 2016-07-28 20:26:40]

Description was changed from

==========
Chooser spinner should disappear as soon as one device shows up

The chooser needs to show devices as they come. So the spinner should
disappear as soon as one device shows up. This can reduce the wait time
and user can select a device more quickly if it is already listed in
the chooser.

I added some screenshots at issue 583452 page.

BUG=583452, 632173
==========

to

==========
Chooser spinner should disappear as soon as one device shows up

The chooser needs to show devices as they come. So the spinner should
disappear as soon as one device shows up. This can reduce the wait time
and user can select a device more quickly if it is already listed in
the chooser.

I added some screenshots at issue 583452.

BUG=583452, 632173
==========

[juncai, 2016-07-28 20:27:17]

juncai@chromium.org changed reviewers:
+ jyasskin@chromium.org, msw@chromium.org, reillyg@chromium.org,
rsesek@chromium.org

[juncai, 2016-07-28 20:27:17]

rsesek@chromium.org: Please review changes in 
//chrome/browser/ui/cocoa/

msw@chromium.org: Please review changes in 
//chrome/browser/ui/views/

reillyg@chromium.org: Please review changes in 
//chrome/browser/chooser_controller/

jyasskin@chromium.org: Please review changes in 
//chrome/browser/ui/bluetooth/

[Reilly Grant (use Gerrit), 2016-07-28 22:03:04]

https://codereview.chromium.org/2192953002/diff/1/chrome/browser/chooser_cont...
File chrome/browser/chooser_controller/chooser_controller.h (right):

https://codereview.chromium.org/2192953002/diff/1/chrome/browser/chooser_cont...
chrome/browser/chooser_controller/chooser_controller.h:57: virtual void
OnOptionAvailableDuringRefresh() = 0;
This method seems unnecessary. If OnOptionAdded() is called while the spinner is
being shown the UI can simply hide the spinner and show the table view again.

[juncai, 2016-07-29 00:43:19]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 00:43:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-07-29 00:45:21]

https://codereview.chromium.org/2192953002/diff/1/chrome/browser/chooser_cont...
File chrome/browser/chooser_controller/chooser_controller.h (right):

https://codereview.chromium.org/2192953002/diff/1/chrome/browser/chooser_cont...
chrome/browser/chooser_controller/chooser_controller.h:57: virtual void
OnOptionAvailableDuringRefresh() = 0;
On 2016/07/28 22:03:04, Reilly Grant wrote:
> This method seems unnecessary. If OnOptionAdded() is called while the spinner
is
> being shown the UI can simply hide the spinner and show the table view again.

Good point! Removed this function.

Done.

[commit-bot: I haz the power, 2016-07-29 02:18:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 02:18:11]

Dry run: This issue passed the CQ dry run.

[msw, 2016-07-29 02:41:40]

lgtm

[Robert Sesek, 2016-07-29 14:42:16]

lgtm

[Reilly Grant (use Gerrit), 2016-07-29 17:35:01]

lgtm for adding jyasskin to //chrome/browser/chooser_controller/OWNERS

[juncai, 2016-07-29 17:58:49]

The CQ bit was checked by juncai@chromium.org

[commit-bot: I haz the power, 2016-07-29 17:59:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 18:02:50]

Description was changed from

==========
Chooser spinner should disappear as soon as one device shows up

The chooser needs to show devices as they come. So the spinner should
disappear as soon as one device shows up. This can reduce the wait time
and user can select a device more quickly if it is already listed in
the chooser.

I added some screenshots at issue 583452.

BUG=583452, 632173
==========

to

==========
Chooser spinner should disappear as soon as one device shows up

The chooser needs to show devices as they come. So the spinner should
disappear as soon as one device shows up. This can reduce the wait time
and user can select a device more quickly if it is already listed in
the chooser.

I added some screenshots at issue 583452.

BUG=583452, 632173
==========

[commit-bot: I haz the power, 2016-07-29 18:02:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-29 18:05:18]

Description was changed from

==========
Chooser spinner should disappear as soon as one device shows up

The chooser needs to show devices as they come. So the spinner should
disappear as soon as one device shows up. This can reduce the wait time
and user can select a device more quickly if it is already listed in
the chooser.

I added some screenshots at issue 583452.

BUG=583452, 632173
==========

to

==========
Chooser spinner should disappear as soon as one device shows up

The chooser needs to show devices as they come. So the spinner should
disappear as soon as one device shows up. This can reduce the wait time
and user can select a device more quickly if it is already listed in
the chooser.

I added some screenshots at issue 583452.

BUG=583452, 632173

Committed: https://crrev.com/3fa2f4f2fe52f652837a96928cf525d4081004ad
Cr-Commit-Position: refs/heads/master@{#408687}
==========

[commit-bot: I haz the power, 2016-07-29 18:05:19]

Patchset 2 (id:??) landed as
https://crrev.com/3fa2f4f2fe52f652837a96928cf525d4081004ad
Cr-Commit-Position: refs/heads/master@{#408687}