Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc

Issue 2192953002: Chooser spinner should disappear as soon as one device shows up (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/views/chooser_content_view_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/extensions/chooser_dialog_view.h" 5 #include "chrome/browser/ui/views/extensions/chooser_dialog_view.h"
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "chrome/browser/chooser_controller/mock_chooser_controller.h" 9 #include "chrome/browser/chooser_controller/mock_chooser_controller.h"
10 #include "chrome/browser/ui/views/chooser_content_view.h" 10 #include "chrome/browser/ui/views/chooser_content_view.h"
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 // becomes invalid, the OK button is disabled. 227 // becomes invalid, the OK button is disabled.
228 EXPECT_FALSE(ok_button_->enabled()); 228 EXPECT_FALSE(ok_button_->enabled());
229 EXPECT_TRUE(cancel_button_->enabled()); 229 EXPECT_TRUE(cancel_button_->enabled());
230 230
231 mock_chooser_controller_->OnAdapterPresenceChanged( 231 mock_chooser_controller_->OnAdapterPresenceChanged(
232 content::BluetoothChooser::AdapterPresence::POWERED_ON); 232 content::BluetoothChooser::AdapterPresence::POWERED_ON);
233 EXPECT_FALSE(ok_button_->enabled()); 233 EXPECT_FALSE(ok_button_->enabled());
234 EXPECT_TRUE(cancel_button_->enabled()); 234 EXPECT_TRUE(cancel_button_->enabled());
235 } 235 }
236 236
237 TEST_F(ChooserDialogViewTest, DiscoveringAndIdle) { 237 TEST_F(ChooserDialogViewTest, DiscoveringAndNoOptionAddedAndIdle) {
238 mock_chooser_controller_->OptionAdded(base::ASCIIToUTF16("a")); 238 mock_chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
239 mock_chooser_controller_->OptionAdded(base::ASCIIToUTF16("b")); 239 mock_chooser_controller_->OptionAdded(base::ASCIIToUTF16("b"));
240 mock_chooser_controller_->OptionAdded(base::ASCIIToUTF16("c")); 240 mock_chooser_controller_->OptionAdded(base::ASCIIToUTF16("c"));
241 table_view_->Select(1); 241 table_view_->Select(1);
242 EXPECT_TRUE(ok_button_->enabled()); 242 EXPECT_TRUE(ok_button_->enabled());
243 EXPECT_TRUE(cancel_button_->enabled()); 243 EXPECT_TRUE(cancel_button_->enabled());
244 244
245 mock_chooser_controller_->OnDiscoveryStateChanged( 245 mock_chooser_controller_->OnDiscoveryStateChanged(
246 content::BluetoothChooser::DiscoveryState::DISCOVERING); 246 content::BluetoothChooser::DiscoveryState::DISCOVERING);
247 // OK button is disabled since the chooser is refreshing options. 247 // OK button is disabled since the chooser is refreshing options.
248 EXPECT_FALSE(ok_button_->enabled()); 248 EXPECT_FALSE(ok_button_->enabled());
249 EXPECT_TRUE(cancel_button_->enabled()); 249 EXPECT_TRUE(cancel_button_->enabled());
250 250
251 mock_chooser_controller_->OnDiscoveryStateChanged( 251 mock_chooser_controller_->OnDiscoveryStateChanged(
252 content::BluetoothChooser::DiscoveryState::IDLE); 252 content::BluetoothChooser::DiscoveryState::IDLE);
253 // OK button is disabled since the chooser refreshed options. 253 // OK button is disabled since the chooser refreshed options.
254 EXPECT_FALSE(ok_button_->enabled()); 254 EXPECT_FALSE(ok_button_->enabled());
255 EXPECT_TRUE(cancel_button_->enabled()); 255 EXPECT_TRUE(cancel_button_->enabled());
256 } 256 }
257
258 TEST_F(ChooserDialogViewTest, DiscoveringAndOneOptionAddedAndSelectedAndIdle) {
259 mock_chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
260 mock_chooser_controller_->OptionAdded(base::ASCIIToUTF16("b"));
261 mock_chooser_controller_->OptionAdded(base::ASCIIToUTF16("c"));
262 table_view_->Select(1);
263
264 mock_chooser_controller_->OnDiscoveryStateChanged(
265 content::BluetoothChooser::DiscoveryState::DISCOVERING);
266 mock_chooser_controller_->OptionAdded(base::ASCIIToUTF16("d"));
267 // OK button is disabled since no option is selected.
268 EXPECT_FALSE(ok_button_->enabled());
269 EXPECT_TRUE(cancel_button_->enabled());
270 table_view_->Select(0);
271 EXPECT_TRUE(ok_button_->enabled());
272 EXPECT_TRUE(cancel_button_->enabled());
273
274 mock_chooser_controller_->OnDiscoveryStateChanged(
275 content::BluetoothChooser::DiscoveryState::IDLE);
276 EXPECT_TRUE(ok_button_->enabled());
277 EXPECT_TRUE(cancel_button_->enabled());
278 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/chooser_content_view_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698