Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7205)

Unified Diff: chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc

Issue 2192953002: Chooser spinner should disappear as soon as one device shows up (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/chooser_content_view_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc
diff --git a/chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc b/chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc
index a38d68ab3fe66ebafeaa47c6b08293c4a6473905..afcedf20e2f75523ebcd5b46d85f47dbfb1661e0 100644
--- a/chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc
+++ b/chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc
@@ -234,7 +234,7 @@ TEST_F(ChooserDialogViewTest, AdapterOnAndOffAndOn) {
EXPECT_TRUE(cancel_button_->enabled());
}
-TEST_F(ChooserDialogViewTest, DiscoveringAndIdle) {
+TEST_F(ChooserDialogViewTest, DiscoveringAndNoOptionAddedAndIdle) {
mock_chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
mock_chooser_controller_->OptionAdded(base::ASCIIToUTF16("b"));
mock_chooser_controller_->OptionAdded(base::ASCIIToUTF16("c"));
@@ -254,3 +254,25 @@ TEST_F(ChooserDialogViewTest, DiscoveringAndIdle) {
EXPECT_FALSE(ok_button_->enabled());
EXPECT_TRUE(cancel_button_->enabled());
}
+
+TEST_F(ChooserDialogViewTest, DiscoveringAndOneOptionAddedAndSelectedAndIdle) {
+ mock_chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
+ mock_chooser_controller_->OptionAdded(base::ASCIIToUTF16("b"));
+ mock_chooser_controller_->OptionAdded(base::ASCIIToUTF16("c"));
+ table_view_->Select(1);
+
+ mock_chooser_controller_->OnDiscoveryStateChanged(
+ content::BluetoothChooser::DiscoveryState::DISCOVERING);
+ mock_chooser_controller_->OptionAdded(base::ASCIIToUTF16("d"));
+ // OK button is disabled since no option is selected.
+ EXPECT_FALSE(ok_button_->enabled());
+ EXPECT_TRUE(cancel_button_->enabled());
+ table_view_->Select(0);
+ EXPECT_TRUE(ok_button_->enabled());
+ EXPECT_TRUE(cancel_button_->enabled());
+
+ mock_chooser_controller_->OnDiscoveryStateChanged(
+ content::BluetoothChooser::DiscoveryState::IDLE);
+ EXPECT_TRUE(ok_button_->enabled());
+ EXPECT_TRUE(cancel_button_->enabled());
+}
« no previous file with comments | « chrome/browser/ui/views/chooser_content_view_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698