Chooser spinner should disappear as soon as one device shows up

chrome/browser/chooser_controller/chooser_controller.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHOOSER_CONTROLLER_CHOOSER_CONTROLLER_H_
 #define CHROME_BROWSER_CHOOSER_CONTROLLER_CHOOSER_CONTROLLER_H_
 
 #include "base/macros.h"
 #include "base/strings/string16.h"
 
@@ skipping 34 matching lines @@
     // from inside a call to OnOptionRemoved will NOT see the removed string
     // since the options have already been updated.
     virtual void OnOptionRemoved(size_t index) = 0;
 
     // Called when the device adapter is turned on or off.
     virtual void OnAdapterEnabledChanged(bool enabled) = 0;
 
     // Called when refreshing options is in progress or complete.
     virtual void OnRefreshStateChanged(bool refreshing) = 0;
 
+    // Called when refreshing options is still in progress but found at least
+    // one option. Only need to be called when the first option is added.
+    virtual void OnOptionAvailableDuringRefresh() = 0;

[Reilly Grant (use Gerrit), 2016/07/28 22:03:04]

This method seems unnecessary. If OnOptionAdded() is called while the spinner is
being shown the UI can simply hide the spinner and show the table view again.

[juncai, 2016/07/29 00:45:21]

Good point! Removed this function.

Done.

+
    protected:
     virtual ~View() {}
   };
 
   // Returns the text to be displayed in the chooser title.
   base::string16 GetTitle() const;
 
   // Returns the text to be displayed in the chooser when there are no options.
   virtual base::string16 GetNoOptionsText() const = 0;
 
@@ skipping 36 matching lines @@
  private:
   content::RenderFrameHost* const owning_frame_;
   const int title_string_id_origin_;
   const int title_string_id_extension_;
   View* view_ = nullptr;
 
   DISALLOW_COPY_AND_ASSIGN(ChooserController);
 };
 
 #endif  // CHROME_BROWSER_CHOOSER_CONTROLLER_CHOOSER_CONTROLLER_H_