Chooser spinner should disappear as soon as one device shows up

chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include <memory>
 #include <vector>
@@ skipping 403 matching lines @@
   ASSERT_FALSE(connect_button_.enabled);
   ASSERT_TRUE(cancel_button_.enabled);
 
   chooser_controller_->OnAdapterPresenceChanged(
       content::BluetoothChooser::AdapterPresence::POWERED_ON);
   EXPECT_EQ(0u, chooser_controller_->NumOptions());
   ASSERT_FALSE(connect_button_.enabled);
   ASSERT_TRUE(cancel_button_.enabled);
 }
 
-TEST_F(ChooserDialogCocoaControllerTest, DiscoveringAndIdle) {
+TEST_F(ChooserDialogCocoaControllerTest, DiscoveringAndNoOptionAddedAndIdle) {
   CreateChooserDialog();
 
   // Add options
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("b"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("c"));
   EXPECT_FALSE(table_view_.hidden);
   ASSERT_TRUE(table_view_.enabled);
   EXPECT_EQ(3, table_view_.numberOfRows);
   // Select option 1.
@@ skipping 27 matching lines @@
   // No option selected.
   EXPECT_EQ(-1, table_view_.selectedRow);
   EXPECT_TRUE(spinner_.hidden);
   EXPECT_TRUE(status_.hidden);
   EXPECT_FALSE(rescan_button_.hidden);
   // OK button is disabled since the chooser refreshed options.
   ASSERT_FALSE(connect_button_.enabled);
   ASSERT_TRUE(cancel_button_.enabled);
 }
 
+TEST_F(ChooserDialogCocoaControllerTest,
+       DiscoveringAndOneOptionAddedAndSelectedAndIdle) {
+  CreateChooserDialog();
+
+  chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
+  chooser_controller_->OptionAdded(base::ASCIIToUTF16("b"));
+  chooser_controller_->OptionAdded(base::ASCIIToUTF16("c"));
+  [table_view_ selectRowIndexes:[NSIndexSet indexSetWithIndex:1]
+           byExtendingSelection:NO];
+
+  chooser_controller_->OnDiscoveryStateChanged(
+      content::BluetoothChooser::DiscoveryState::DISCOVERING);
+  chooser_controller_->OptionAdded(base::ASCIIToUTF16("d"));
+  EXPECT_FALSE(table_view_.hidden);
+  // |table_view_| should be enabled since there is an option.
+  ASSERT_TRUE(table_view_.enabled);
+  EXPECT_EQ(1, table_view_.numberOfRows);
+  // No option selected.
+  EXPECT_EQ(-1, table_view_.selectedRow);
+  EXPECT_TRUE(spinner_.hidden);
+  EXPECT_FALSE(status_.hidden);
+  EXPECT_TRUE(rescan_button_.hidden);
+  // OK button is disabled since no option is selected.
+  ASSERT_FALSE(connect_button_.enabled);
+  ASSERT_TRUE(cancel_button_.enabled);
+  [table_view_ selectRowIndexes:[NSIndexSet indexSetWithIndex:0]
+           byExtendingSelection:NO];
+  EXPECT_EQ(0, table_view_.selectedRow);
+  ASSERT_TRUE(connect_button_.enabled);
+  ASSERT_TRUE(cancel_button_.enabled);
+
+  chooser_controller_->OnDiscoveryStateChanged(
+      content::BluetoothChooser::DiscoveryState::IDLE);
+  EXPECT_FALSE(table_view_.hidden);
+  ASSERT_TRUE(table_view_.enabled);
+  EXPECT_EQ(1, table_view_.numberOfRows);
+  EXPECT_EQ(0, table_view_.selectedRow);
+  EXPECT_TRUE(spinner_.hidden);
+  EXPECT_TRUE(status_.hidden);
+  EXPECT_FALSE(rescan_button_.hidden);
+  ASSERT_TRUE(connect_button_.enabled);
+  ASSERT_TRUE(cancel_button_.enabled);
+}
+
 TEST_F(ChooserDialogCocoaControllerTest, PressRescanButton) {
   CreateChooserDialog();
 
   EXPECT_CALL(*chooser_controller_, RefreshOptions()).Times(1);
   [rescan_button_ performClick:chooser_dialog_controller_];
 }
 
 TEST_F(ChooserDialogCocoaControllerTest, PressHelpButton) {
   CreateChooserDialog();
 
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("b"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("c"));
 
   // Select option 0 and press "Get help" button.
   [table_view_ selectRowIndexes:[NSIndexSet indexSetWithIndex:0]
            byExtendingSelection:NO];
   EXPECT_CALL(*chooser_controller_, Select(testing::_)).Times(0);
   EXPECT_CALL(*chooser_controller_, Cancel()).Times(0);
   EXPECT_CALL(*chooser_controller_, OpenHelpCenterUrl()).Times(1);
   [help_button_ performClick:chooser_dialog_controller_];
 }