Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2191343002: 📰 Remove SnippetService's dependency on Sync (Closed)

Created:
4 years, 4 months ago by dgn
Modified:
4 years, 4 months ago
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Client] Remove SnippetService's dependency on Sync The SnippetService doesn't care about the sync state anymore so we can get rid of that dependency. BUG=627488 TBR=noyau@chromium.org Committed: https://crrev.com/c09dbeacff156f8712fcb69bd65188d11a711096 Cr-Commit-Position: refs/heads/master@{#408650}

Patch Set 1 #

Patch Set 2 : update some doc, show NO_SNIPPETS instead of SIGNIN when during INITIALIZING state #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -240 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusListItem.java View 1 3 chunks +3 lines, -68 lines 0 comments Download
M chrome/browser/ntp_snippets/ntp_snippets_service_factory.cc View 4 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/ui/webui/snippets_internals_message_handler.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M components/ntp_snippets/content_suggestions_category_status.h View 1 chunk +0 lines, -7 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service.h View 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_snippets/ntp_snippets_service.cc View 2 chunks +0 lines, -25 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_status_service.h View 1 4 chunks +16 lines, -26 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_status_service.cc View 4 chunks +14 lines, -31 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_status_service_unittest.cc View 4 chunks +4 lines, -42 lines 0 comments Download
M components/ntp_snippets_strings.grdp View 1 chunk +0 lines, -15 lines 0 comments Download
M ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc View 5 chunks +2 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (11 generated)
dgn
PTAL
4 years, 4 months ago (2016-07-29 13:24:13 UTC) #6
noyau (Ping after 24h)
ios/ lgtm
4 years, 4 months ago (2016-07-29 13:28:47 UTC) #7
Bernhard Bauer
Wow. Many delete. Such LGTM.
4 years, 4 months ago (2016-07-29 13:29:15 UTC) #8
dgn
Thanks!
4 years, 4 months ago (2016-07-29 13:32:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191343002/20001
4 years, 4 months ago (2016-07-29 13:33:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191343002/20001
4 years, 4 months ago (2016-07-29 16:12:36 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 16:16:24 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 16:19:10 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c09dbeacff156f8712fcb69bd65188d11a711096
Cr-Commit-Position: refs/heads/master@{#408650}

Powered by Google App Engine
This is Rietveld 408576698