components/ntp_snippets/ntp_snippets_service_unittest.cc - Issue 2191343002: 📰 Remove SnippetService's dependency on Sync

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/ntp_snippets_service_unittest.cc

Issue 2191343002: 📰 Remove SnippetService's dependency on Sync (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update some doc, show NO_SNIPPETS instead of SIGNIN when during INITIALIZING state Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ntp_snippets/ntp_snippets_service_unittest.cc

diff --git a/components/ntp_snippets/ntp_snippets_service_unittest.cc b/components/ntp_snippets/ntp_snippets_service_unittest.cc

index 9d56af38b90dc1b5d961c3ee86a7914847bb83a3..b5d01dc79c60c3629f2f7d77e536b11215300b3d 100644

--- a/components/ntp_snippets/ntp_snippets_service_unittest.cc

+++ b/components/ntp_snippets/ntp_snippets_service_unittest.cc

@@ -329,8 +329,8 @@ class NTPSnippetsServiceTest : public test::NTPSnippetsTestBase {

std::move(snippets_fetcher), /*image_fetcher=*/nullptr,

/*image_fetcher=*/nullptr, base::MakeUnique<NTPSnippetsDatabase>(

database_dir_.path(), task_runner),

- base::MakeUnique<NTPSnippetsStatusService>(

- fake_signin_manager(), mock_sync_service(), pref_service())));

+ base::MakeUnique<NTPSnippetsStatusService>(fake_signin_manager(),

+ pref_service())));

if (enabled)

WaitForDBLoad(service_.get());

@@ -867,7 +867,7 @@ TEST_F(NTPSnippetsServiceTest, DismissShouldRespectAllKnownUrls) {

ASSERT_THAT(service()->snippets(), IsEmpty());

}

-TEST_F(NTPSnippetsServiceTest, HistorySyncStateChanges) {

+TEST_F(NTPSnippetsServiceTest, StatusChanges) {

MockServiceObserver mock_observer;

service()->AddObserver(&mock_observer);