components/ntp_snippets_strings.grdp - Issue 2191343002: 📰 Remove SnippetService's dependency on Sync

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets_strings.grdp

Issue 2191343002: 📰 Remove SnippetService's dependency on Sync (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update some doc, show NO_SNIPPETS instead of SIGNIN when during INITIALIZING state Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/ntp_snippets_status_service_unittest.cc ('k') | ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets_strings.grdp

diff --git a/components/ntp_snippets_strings.grdp b/components/ntp_snippets_strings.grdp

index a7425c110079c8502da1174416ff6b95874f8cc0..b4407fde27351d054949c15d455f85cc6e0631b5 100644

--- a/components/ntp_snippets_strings.grdp

+++ b/components/ntp_snippets_strings.grdp

@@ -8,21 +8,6 @@

Get suggested content

</message>

- <message name="IDS_SNIPPETS_DISABLED_SYNC_INSTRUCTIONS" desc="Body of the card explaining the status of the NTP suggested content, when sync is disabled." formatter_data="android_java">

- To get personalized content suggested by Google, turn on sync.

- </message>

- <message name="IDS_SNIPPETS_DISABLED_SYNC_ACTION" desc="Label of the action button for the card explaining the status of the NTP suggested content, when sync is disabled." formatter_data="android_java">

- Turn on sync

- </message>

- <message name="IDS_SNIPPETS_DISABLED_HISTORY_SYNC_INSTRUCTIONS" desc="Body of the card explaining the status of the NTP suggested content, when history sync is disabled." formatter_data="android_java">

- To get personalized content suggested by Google, turn on history sync.

- </message>

- <message name="IDS_SNIPPETS_DISABLED_HISTORY_SYNC_ACTION" desc="Label of the action button for the card explaining the status of the NTP suggested content, when history sync is disabled." formatter_data="android_java">

- Turn on history sync

- </message>

- <message name="IDS_SNIPPETS_DISABLED_PASSPHRASE_INSTRUCTIONS" desc="Body of the card explaining the status of the NTP suggested content, when passphrase encryption is enabled." formatter_data="android_java">

- Personalized content suggestions are currently disabled, because your synced data is protected with a custom passphrase.

- </message>

</if>

</grit-part>