Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc

Issue 2191343002: 📰 Remove SnippetService's dependency on Sync (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update some doc, show NO_SNIPPETS instead of SIGNIN when during INITIALIZING state Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/ntp_snippets_strings.grdp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc
diff --git a/ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc b/ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc
index 655623f4a1be0cf67a653cf7ff8204d86b964192..66efa50019817b8b95a880fd3032077e504a72a2 100644
--- a/ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc
+++ b/ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc
@@ -10,7 +10,6 @@
#include "base/memory/singleton.h"
#include "base/threading/thread_task_runner_handle.h"
#include "base/values.h"
-#include "components/browser_sync/browser/profile_sync_service.h"
#include "components/image_fetcher/image_decoder.h"
#include "components/image_fetcher/image_fetcher.h"
#include "components/keyed_service/ios/browser_state_dependency_manager.h"
@@ -28,7 +27,6 @@
#include "ios/chrome/browser/suggestions/image_fetcher_impl.h"
#include "ios/chrome/browser/suggestions/ios_image_decoder_impl.h"
#include "ios/chrome/browser/suggestions/suggestions_service_factory.h"
-#include "ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.h"
#include "ios/chrome/common/channel_info.h"
#include "ios/web/public/browser_state.h"
#include "ios/web/public/web_thread.h"
@@ -78,7 +76,6 @@ IOSChromeNTPSnippetsServiceFactory::IOSChromeNTPSnippetsServiceFactory()
"NTPSnippetsService",
BrowserStateDependencyManager::GetInstance()) {
DependsOn(OAuth2TokenServiceFactory::GetInstance());
- DependsOn(IOSChromeProfileSyncServiceFactory::GetInstance());
DependsOn(ios::SigninManagerFactory::GetInstance());
DependsOn(SuggestionsServiceFactory::GetInstance());
}
@@ -97,9 +94,6 @@ IOSChromeNTPSnippetsServiceFactory::BuildServiceInstanceFor(
OAuth2TokenServiceFactory::GetForBrowserState(chrome_browser_state);
scoped_refptr<net::URLRequestContextGetter> request_context =
browser_state->GetRequestContext();
- ProfileSyncService* sync_service =
- IOSChromeProfileSyncServiceFactory::GetForBrowserState(
- chrome_browser_state);
SuggestionsService* suggestions_service =
SuggestionsServiceFactory::GetForBrowserState(chrome_browser_state);
@@ -128,6 +122,6 @@ IOSChromeNTPSnippetsServiceFactory::BuildServiceInstanceFor(
base::MakeUnique<IOSImageDecoderImpl>(),
base::WrapUnique(
new ntp_snippets::NTPSnippetsDatabase(database_dir, task_runner)),
- base::WrapUnique(new ntp_snippets::NTPSnippetsStatusService(
- signin_manager, sync_service, prefs))));
+ base::WrapUnique(
+ new ntp_snippets::NTPSnippetsStatusService(signin_manager, prefs))));
}
« no previous file with comments | « components/ntp_snippets_strings.grdp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698