components/ntp_snippets/ntp_snippets_service.h - Issue 2191343002: 📰 Remove SnippetService's dependency on Sync

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/ntp_snippets_service.h

Issue 2191343002: 📰 Remove SnippetService's dependency on Sync (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update some doc, show NO_SNIPPETS instead of SIGNIN when during INITIALIZING state Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ntp_snippets/ntp_snippets_service.h

diff --git a/components/ntp_snippets/ntp_snippets_service.h b/components/ntp_snippets/ntp_snippets_service.h

index 0d4a1226f36ed6fe65f53fd3af1a4d9768402eb5..808e1910fd47532845e4b0112f1b843ca2613928 100644

--- a/components/ntp_snippets/ntp_snippets_service.h

+++ b/components/ntp_snippets/ntp_snippets_service.h

@@ -160,7 +160,7 @@ class NTPSnippetsService : public KeyedService,

private:

friend class NTPSnippetsServiceTest;

- FRIEND_TEST_ALL_PREFIXES(NTPSnippetsServiceTest, HistorySyncStateChanges);

+ FRIEND_TEST_ALL_PREFIXES(NTPSnippetsServiceTest, StatusChanges);

// TODO(pke): As soon as the DisabledReason is replaced with the new status,

// also remove the old State enum and replace it with