Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2190723005: Remove dom_loading from page_load_metrics (Closed)

Created:
4 years, 4 months ago by Bryan McQuade
Modified:
4 years, 4 months ago
Reviewers:
Tom Sepez, shivanisha
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dom_loading from page_load_metrics dom_loading has been deprecated in the navigation timing spec, so we are removing it from page_load_metrics metrics as well. See https://github.com/w3c/navigation-timing/issues/13 for more details. BUG=632331 Committed: https://crrev.com/be5dee1c8115184d96d97327e6e66e8eb035be92 Cr-Commit-Position: refs/heads/master@{#409009}

Patch Set 1 #

Patch Set 2 : revert unrelated change #

Patch Set 3 : fix test #

Patch Set 4 : rebase #

Messages

Total messages: 35 (26 generated)
Bryan McQuade
PTAL
4 years, 4 months ago (2016-07-28 14:26:01 UTC) #10
shivanisha
On 2016/07/28 at 14:26:01, bmcquade wrote: > PTAL LGTM. Thanks!
4 years, 4 months ago (2016-08-01 16:16:55 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190723005/80001
4 years, 4 months ago (2016-08-01 16:25:01 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/228606)
4 years, 4 months ago (2016-08-01 16:30:10 UTC) #27
Bryan McQuade
tsepez, PTAL for page_load_metrics_messages.h change. Thanks!
4 years, 4 months ago (2016-08-01 16:31:42 UTC) #29
Tom Sepez
RS LGTM on removing member from existing struct.
4 years, 4 months ago (2016-08-01 16:44:08 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190723005/80001
4 years, 4 months ago (2016-08-01 18:44:26 UTC) #32
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 4 months ago (2016-08-01 18:49:14 UTC) #33
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 18:57:56 UTC) #35
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/be5dee1c8115184d96d97327e6e66e8eb035be92
Cr-Commit-Position: refs/heads/master@{#409009}

Powered by Google App Engine
This is Rietveld 408576698