Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: chrome/common/page_load_metrics/page_load_timing.cc

Issue 2190723005: Remove dom_loading from page_load_metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/page_load_metrics/page_load_timing.cc
diff --git a/chrome/common/page_load_metrics/page_load_timing.cc b/chrome/common/page_load_metrics/page_load_timing.cc
index b406334a5762d63f6899a269f0958afd61cff6d7..21c3204489a6074d4735cb44d5676af36e648587 100644
--- a/chrome/common/page_load_metrics/page_load_timing.cc
+++ b/chrome/common/page_load_metrics/page_load_timing.cc
@@ -15,7 +15,6 @@ PageLoadTiming::~PageLoadTiming() {}
bool PageLoadTiming::operator==(const PageLoadTiming& other) const {
return navigation_start == other.navigation_start &&
response_start == other.response_start &&
- dom_loading == other.dom_loading &&
dom_content_loaded_event_start ==
other.dom_content_loaded_event_start &&
load_event_start == other.load_event_start &&
@@ -32,7 +31,7 @@ bool PageLoadTiming::operator==(const PageLoadTiming& other) const {
}
bool PageLoadTiming::IsEmpty() const {
- return navigation_start.is_null() && !response_start && !dom_loading &&
+ return navigation_start.is_null() && !response_start &&
!dom_content_loaded_event_start && !load_event_start &&
!first_layout && !first_paint && !first_text_paint &&
!first_image_paint && !first_contentful_paint && !parse_start &&
« no previous file with comments | « chrome/common/page_load_metrics/page_load_timing.h ('k') | chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698