Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Side by Side Diff: chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc

Issue 2190723005: Remove dom_loading from page_load_metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/page_load_metrics/page_load_timing.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/page_load_metrics/metrics_render_frame_observer.h" 5 #include "chrome/renderer/page_load_metrics/metrics_render_frame_observer.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 117
118 PageLoadTiming MetricsRenderFrameObserver::GetTiming() const { 118 PageLoadTiming MetricsRenderFrameObserver::GetTiming() const {
119 const blink::WebPerformance& perf = 119 const blink::WebPerformance& perf =
120 render_frame()->GetWebFrame()->performance(); 120 render_frame()->GetWebFrame()->performance();
121 121
122 PageLoadTiming timing; 122 PageLoadTiming timing;
123 double start = perf.navigationStart(); 123 double start = perf.navigationStart();
124 timing.navigation_start = base::Time::FromDoubleT(start); 124 timing.navigation_start = base::Time::FromDoubleT(start);
125 if (perf.responseStart() > 0.0) 125 if (perf.responseStart() > 0.0)
126 timing.response_start = ClampDelta(perf.responseStart(), start); 126 timing.response_start = ClampDelta(perf.responseStart(), start);
127 if (perf.domLoading() > 0.0)
128 timing.dom_loading = ClampDelta(perf.domLoading(), start);
129 if (perf.domContentLoadedEventStart() > 0.0) 127 if (perf.domContentLoadedEventStart() > 0.0)
130 timing.dom_content_loaded_event_start = 128 timing.dom_content_loaded_event_start =
131 ClampDelta(perf.domContentLoadedEventStart(), start); 129 ClampDelta(perf.domContentLoadedEventStart(), start);
132 if (perf.loadEventStart() > 0.0) 130 if (perf.loadEventStart() > 0.0)
133 timing.load_event_start = ClampDelta(perf.loadEventStart(), start); 131 timing.load_event_start = ClampDelta(perf.loadEventStart(), start);
134 if (perf.firstLayout() > 0.0) 132 if (perf.firstLayout() > 0.0)
135 timing.first_layout = ClampDelta(perf.firstLayout(), start); 133 timing.first_layout = ClampDelta(perf.firstLayout(), start);
136 if (perf.firstPaint() > 0.0) 134 if (perf.firstPaint() > 0.0)
137 timing.first_paint = ClampDelta(perf.firstPaint(), start); 135 timing.first_paint = ClampDelta(perf.firstPaint(), start);
138 if (perf.firstTextPaint() > 0.0) 136 if (perf.firstTextPaint() > 0.0)
(...skipping 27 matching lines...) Expand all
166 bool no_frame = !render_frame() || !render_frame()->GetWebFrame(); 164 bool no_frame = !render_frame() || !render_frame()->GetWebFrame();
167 DCHECK(!no_frame); 165 DCHECK(!no_frame);
168 return no_frame; 166 return no_frame;
169 } 167 }
170 168
171 void MetricsRenderFrameObserver::OnDestruct() { 169 void MetricsRenderFrameObserver::OnDestruct() {
172 delete this; 170 delete this;
173 } 171 }
174 172
175 } // namespace page_load_metrics 173 } // namespace page_load_metrics
OLDNEW
« no previous file with comments | « chrome/common/page_load_metrics/page_load_timing.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698