chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc - Issue 2190723005: Remove dom_loading from page_load_metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

Issue 2190723005: Remove dom_loading from page_load_metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc ('k') | chrome/common/page_load_metrics/page_load_metrics_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

diff --git a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

index b1c61b20c923fb9d6cbd0cf841d64a02209c2a1e..244d30723497436130320cec743d3f45e555eca1 100644

--- a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

+++ b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

@@ -70,15 +70,12 @@ void PageLoadMetricsObserverTestHarness::PopulateRequiredTimingFields(

inout_timing->dom_content_loaded_event_start =

inout_timing->load_event_start;

}

- if (inout_timing->first_layout && !inout_timing->dom_loading) {

- inout_timing->dom_loading = inout_timing->first_layout;

+ if (inout_timing->first_layout && !inout_timing->parse_start) {

+ inout_timing->parse_start = inout_timing->first_layout;

}

if (inout_timing->dom_content_loaded_event_start &&

- !inout_timing->dom_loading) {

- inout_timing->dom_loading = inout_timing->dom_content_loaded_event_start;

- }

- if (inout_timing->dom_loading && !inout_timing->parse_start) {

- inout_timing->parse_start = inout_timing->dom_loading;

+ !inout_timing->parse_stop) {

+ inout_timing->parse_stop = inout_timing->dom_content_loaded_event_start;

}

if (inout_timing->parse_stop && !inout_timing->parse_start) {

inout_timing->parse_start = inout_timing->parse_stop;

@@ -86,9 +83,6 @@ void PageLoadMetricsObserverTestHarness::PopulateRequiredTimingFields(

if (inout_timing->parse_start && !inout_timing->response_start) {

inout_timing->response_start = inout_timing->parse_start;

}

- if (inout_timing->dom_loading && !inout_timing->response_start) {

- inout_timing->response_start = inout_timing->dom_loading;

- }

if (inout_timing->parse_start) {

if (!inout_timing->parse_blocked_on_script_load_duration)

inout_timing->parse_blocked_on_script_load_duration = base::TimeDelta();