Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5778)

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

Issue 2190723005: Remove dom_loading from page_load_metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
index 4dbb520032945934339bf6fdbe66efbc95d97c47..9944dcb7f9b2e951c03243a1de7de3bf78634d3c 100644
--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
@@ -92,14 +92,6 @@ bool IsValidPageLoadTiming(const PageLoadTiming& timing) {
// Verify proper ordering between the various timings.
- if (!EventsInOrder(timing.response_start, timing.dom_loading)) {
- // We sometimes get a zero response_start with a non-zero DOM loading. See
- // crbug.com/590212.
- DLOG(ERROR) << "Invalid response_start " << timing.response_start
- << " for dom_loading " << timing.dom_loading;
- return false;
- }
-
if (!EventsInOrder(timing.response_start, timing.parse_start)) {
// We sometimes get a zero response_start with a non-zero parse start. See
// crbug.com/590212.
@@ -135,9 +127,9 @@ bool IsValidPageLoadTiming(const PageLoadTiming& timing) {
return false;
}
- if (!EventsInOrder(timing.dom_loading,
+ if (!EventsInOrder(timing.parse_stop,
timing.dom_content_loaded_event_start)) {
- NOTREACHED() << "Invalid dom_loading " << timing.dom_loading
+ NOTREACHED() << "Invalid parse_stop " << timing.parse_stop
<< " for dom_content_loaded_event_start "
<< timing.dom_content_loaded_event_start;
return false;
@@ -151,8 +143,8 @@ bool IsValidPageLoadTiming(const PageLoadTiming& timing) {
return false;
}
- if (!EventsInOrder(timing.dom_loading, timing.first_layout)) {
- NOTREACHED() << "Invalid dom_loading " << timing.dom_loading
+ if (!EventsInOrder(timing.parse_start, timing.first_layout)) {
+ NOTREACHED() << "Invalid parse_start " << timing.parse_start
<< " for first_layout " << timing.first_layout;
return false;
}
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698