Command buffer: feedback loop detection for CopyTexSubImage3D

Command buffer: feedback loop detection for CopyTexSubImage3D

BUG=631934
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/b29cee86b63c0d22a3f80cfa151895b840ec94c7
Cr-Commit-Position: refs/heads/master@{#408611}

[yunchao, 2016-07-28 06:57:03]

Description was changed from

==========
Command buffer: feedback loop detection for CopyTexSubImage3D

BUG=
==========

to

==========
Command buffer: feedback loop detection for CopyTexSubImage3D

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[yunchao, 2016-07-28 10:52:29]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 10:52:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yunchao, 2016-07-28 10:53:02]

Description was changed from

==========
Command buffer: feedback loop detection for CopyTexSubImage3D

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Command buffer: feedback loop detection for CopyTexSubImage3D

BUG=631934
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-07-28 11:29:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 11:29:10]

Dry run: This issue passed the CQ dry run.

[yunchao, 2016-07-28 12:48:50]

yunchao.he@intel.com changed reviewers:
+ kbr@chromium.org, piman@chromium.org, qiankun.miao@intel.com, zmo@chromium.org

[yunchao, 2016-07-28 12:50:02]

The 2nd patch. This change detects feedback loop for CopyTexSubImage3D. 

PTAL. Thanks a lot!

[qiankun, 2016-07-28 13:59:31]

nice patch.

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/framebuffer_manager.cc (right):

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/framebuffer_manager.cc:313: level == level_ && layer
== layer_;
I suggest 4 space indent to return.

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:4249: if
(feature_info_->IsWebGL2OrES3Context() ||
Can you explain why webgl2 or es3 are different here?

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:4298: Framebuffer* framebuffer =
NULL;
Use nullptr.

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc (right):

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc:1326: 
Extra new-line.

[Zhenyao Mo, 2016-07-28 14:51:37]

Mostly looks good with some minor issues.

Also, can you add a webgl2 conformance test that fails without this CL and
succeeds with it? We will want other browsers also follow this rule.

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:4249: if
(feature_info_->IsWebGL2OrES3Context() ||
I don't think this is necessary.  chromium_framebuffer_multisample has to be
true if it's WebGL2 or ES3.

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:4300: framebuffer =
GetFramebufferInfoForTarget(GL_READ_FRAMEBUFFER_EXT);
I don't think it's necessary.  is_webgl2_or_es3 is always true if
features().chromium_framebuffer_multisample is true. The original code is
enough.

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:4308: const
Framebuffer::Attachment* attachment = is_webgl2_or_es3 ?
This is unnecessary.  In ES2 READ_BUFFER is just COLOR_ATTACHMENT0.

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc (right):

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc:1238:
CopyTexSubImage3D cmd;
This is weird.  Why one has namespace cmds and the other doesn't?

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc:1281:
DoTexImage3D(kTarget, kLevel, kInternalFormat, kWidth, kHeight, kDepth,
You don't need to re-setup the texture again.

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc:1311:
DoTexImage3D(kTarget, kLevel, kInternalFormat, kWidth, kHeight, kDepth,
Same here.

[yunchao, 2016-07-28 15:04:05]

Thanks for your review, Zhenyao. I have one question inline. Could you double
check about this?

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:4308: const
Framebuffer::Attachment* attachment = is_webgl2_or_es3 ?
On 2016/07/28 14:51:37, Zhenyao Mo wrote:
> This is unnecessary.  In ES2 READ_BUFFER is just COLOR_ATTACHMENT0.
Why here is not necessary, Zhenyao? I don't understand. What if we set read
buffer by readBuffer() to other attachment instead of COLOR_ATTACHMENT0? 
You can also see the code GLES2DecoderImpl::DoReadBuffer() ->
FramebufferManager::set_read_buffer(). And
Framebuffer::GetReadBufferAttachment() will get the correct read attachment when
binding to a fbo.

Well, I know that in ES2 or WebGL 1, the read buffer is definitely
COLOR_ATTACHMENT0. But you know, for WebGL 2 or ES3, we have readBuffer() API to
change the read buffer attachment.

[yunchao, 2016-07-28 15:06:05]

Sorry to bother you, I know what you mean...

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:4308: const
Framebuffer::Attachment* attachment = is_webgl2_or_es3 ?
On 2016/07/28 15:04:04, yunchao wrote:
> On 2016/07/28 14:51:37, Zhenyao Mo wrote:
> > This is unnecessary.  In ES2 READ_BUFFER is just COLOR_ATTACHMENT0.
> Why here is not necessary, Zhenyao? I don't understand. What if we set read
> buffer by readBuffer() to other attachment instead of COLOR_ATTACHMENT0? 
> You can also see the code GLES2DecoderImpl::DoReadBuffer() ->
> FramebufferManager::set_read_buffer(). And
> Framebuffer::GetReadBufferAttachment() will get the correct read attachment
when
> binding to a fbo.
> 
> Well, I know that in ES2 or WebGL 1, the read buffer is definitely
> COLOR_ATTACHMENT0. But you know, for WebGL 2 or ES3, we have readBuffer() API
to
> change the read buffer attachment. 

Sorry, I got what you mean. We can only use
framebuffer->GetReadBufferAttachment() to cover all situations.

[Zhenyao Mo, 2016-07-28 15:06:38]

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:4308: const
Framebuffer::Attachment* attachment = is_webgl2_or_es3 ?
On 2016/07/28 15:04:04, yunchao wrote:
> On 2016/07/28 14:51:37, Zhenyao Mo wrote:
> > This is unnecessary.  In ES2 READ_BUFFER is just COLOR_ATTACHMENT0.
> Why here is not necessary, Zhenyao? I don't understand. What if we set read
> buffer by readBuffer() to other attachment instead of COLOR_ATTACHMENT0? 
> You can also see the code GLES2DecoderImpl::DoReadBuffer() ->
> FramebufferManager::set_read_buffer(). And
> Framebuffer::GetReadBufferAttachment() will get the correct read attachment
when
> binding to a fbo.
> 
> Well, I know that in ES2 or WebGL 1, the read buffer is definitely
> COLOR_ATTACHMENT0. But you know, for WebGL 2 or ES3, we have readBuffer() API
to
> change the read buffer attachment. 

What I mean is you can always call framebuffer->GetReadBufferAttachment().

[yunchao, 2016-07-28 15:31:22]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 15:31:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 15:35:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 15:35:13]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[yunchao, 2016-07-28 15:41:06]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 15:41:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yunchao, 2016-07-28 15:53:06]

Code has been updated, Zhenyao and all. Please take another look. Thanks a lot!

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/framebuffer_manager.cc (right):

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/framebuffer_manager.cc:313: level == level_ && layer
== layer_;
On 2016/07/28 13:59:31, qiankun wrote:
> I suggest 4 space indent to return.

Done.

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:4249: if
(feature_info_->IsWebGL2OrES3Context() ||
On 2016/07/28 14:51:37, Zhenyao Mo wrote:
> I don't think this is necessary.  chromium_framebuffer_multisample has to be
> true if it's WebGL2 or ES3.

Got it.

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:4249: if
(feature_info_->IsWebGL2OrES3Context() ||
On 2016/07/28 13:59:31, qiankun wrote:
> Can you explain why webgl2 or es3 are different here? 

For read buffer, we should get info from GL_READ_FRAMEBUFFER for webgl 2 or es3,
instead of GL_FRAMEBUFFER(Which is identical to GL_DRAW_FRAMEBUFFER). 
However, as Zhenyao pointed out, the chromium_framebuffer_multisample should be
true for webgl2 or es3 context.

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:4300: framebuffer =
GetFramebufferInfoForTarget(GL_READ_FRAMEBUFFER_EXT);
On 2016/07/28 14:51:37, Zhenyao Mo wrote:
> I don't think it's necessary.  is_webgl2_or_es3 is always true if
> features().chromium_framebuffer_multisample is true. The original code is
> enough.

Done.

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:4308: const
Framebuffer::Attachment* attachment = is_webgl2_or_es3 ?
On 2016/07/28 15:06:38, Zhenyao Mo wrote:
> On 2016/07/28 15:04:04, yunchao wrote:
> > On 2016/07/28 14:51:37, Zhenyao Mo wrote:
> > > This is unnecessary.  In ES2 READ_BUFFER is just COLOR_ATTACHMENT0.
> > Why here is not necessary, Zhenyao? I don't understand. What if we set read
> > buffer by readBuffer() to other attachment instead of COLOR_ATTACHMENT0? 
> > You can also see the code GLES2DecoderImpl::DoReadBuffer() ->
> > FramebufferManager::set_read_buffer(). And
> > Framebuffer::GetReadBufferAttachment() will get the correct read attachment
> when
> > binding to a fbo.
> > 
> > Well, I know that in ES2 or WebGL 1, the read buffer is definitely
> > COLOR_ATTACHMENT0. But you know, for WebGL 2 or ES3, we have readBuffer()
API
> to
> > change the read buffer attachment. 
> 
> What I mean is you can always call framebuffer->GetReadBufferAttachment().

Yeah.

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:4308: const
Framebuffer::Attachment* attachment = is_webgl2_or_es3 ?
On 2016/07/28 15:06:38, Zhenyao Mo wrote:
> On 2016/07/28 15:04:04, yunchao wrote:
> > On 2016/07/28 14:51:37, Zhenyao Mo wrote:
> > > This is unnecessary.  In ES2 READ_BUFFER is just COLOR_ATTACHMENT0.
> > Why here is not necessary, Zhenyao? I don't understand. What if we set read
> > buffer by readBuffer() to other attachment instead of COLOR_ATTACHMENT0? 
> > You can also see the code GLES2DecoderImpl::DoReadBuffer() ->
> > FramebufferManager::set_read_buffer(). And
> > Framebuffer::GetReadBufferAttachment() will get the correct read attachment
> when
> > binding to a fbo.
> > 
> > Well, I know that in ES2 or WebGL 1, the read buffer is definitely
> > COLOR_ATTACHMENT0. But you know, for WebGL 2 or ES3, we have readBuffer()
API
> to
> > change the read buffer attachment. 
> 
> What I mean is you can always call framebuffer->GetReadBufferAttachment().

Yeah.

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc (right):

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc:1238:
CopyTexSubImage3D cmd;
On 2016/07/28 14:51:37, Zhenyao Mo wrote:
> This is weird.  Why one has namespace cmds and the other doesn't?

cmds namespace is not necessary. removed

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc:1281:
DoTexImage3D(kTarget, kLevel, kInternalFormat, kWidth, kHeight, kDepth,
On 2016/07/28 14:51:37, Zhenyao Mo wrote:
> You don't need to re-setup the texture again.

Done.

https://codereview.chromium.org/2190543005/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc:1311:
DoTexImage3D(kTarget, kLevel, kInternalFormat, kWidth, kHeight, kDepth,
On 2016/07/28 14:51:37, Zhenyao Mo wrote:
> Same here.

Done.

[yunchao, 2016-07-28 15:57:32]

On 2016/07/28 14:51:37, Zhenyao Mo wrote:
> Mostly looks good with some minor issues.
> 
> Also, can you add a webgl2 conformance test that fails without this CL and
> succeeds with it? We will want other browsers also follow this rule.

Sure, I will add conformance test into WebGL 2 CTS to cover feedback loop.

[Zhenyao Mo, 2016-07-28 16:14:37]

LGTM

[commit-bot: I haz the power, 2016-07-28 17:02:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 17:02:06]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[piman, 2016-07-28 20:30:21]

lgtm

[yunchao, 2016-07-28 23:59:20]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 23:59:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 01:01:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 01:01:53]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yunchao, 2016-07-29 02:29:49]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 02:30:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 03:30:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 03:30:24]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yunchao, 2016-07-29 05:21:00]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 05:21:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 06:16:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 06:16:50]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yunchao, 2016-07-29 06:53:13]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 06:53:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 07:38:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 07:38:21]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yunchao, 2016-07-29 08:37:21]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 08:37:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yunchao, 2016-07-29 08:45:22]

Patchset #5 (id:80001) has been deleted

[yunchao, 2016-07-29 08:45:36]

Patchset #5 (id:100001) has been deleted

[yunchao, 2016-07-29 09:15:42]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 09:15:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 10:05:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 10:05:08]

Dry run: This issue passed the CQ dry run.

[yunchao, 2016-07-29 10:09:42]

On 2016/07/28 20:30:21, piman - slow reviews until 8-8 wrote:
> lgtm

@zmo and @piman, I split the tests in gpu_unittests into multiple ones. FYI. 
landing now...

[yunchao, 2016-07-29 10:10:46]

The CQ bit was checked by yunchao.he@intel.com

[yunchao, 2016-07-29 10:10:46]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2190543005/#ps140001
(title: "Fix bot failure: split tests, previous calls to CopyTexSubImage3D may
make framebuffer incomplete")

[commit-bot: I haz the power, 2016-07-29 10:11:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 10:14:35]

Description was changed from

==========
Command buffer: feedback loop detection for CopyTexSubImage3D

BUG=631934
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Command buffer: feedback loop detection for CopyTexSubImage3D

BUG=631934
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-07-29 10:14:36]

Committed patchset #6 (id:140001)

[commit-bot: I haz the power, 2016-07-29 10:16:43]

Description was changed from

==========
Command buffer: feedback loop detection for CopyTexSubImage3D

BUG=631934
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Command buffer: feedback loop detection for CopyTexSubImage3D

BUG=631934
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/b29cee86b63c0d22a3f80cfa151895b840ec94c7
Cr-Commit-Position: refs/heads/master@{#408611}
==========

[commit-bot: I haz the power, 2016-07-29 10:16:46]

Patchset 6 (id:??) landed as
https://crrev.com/b29cee86b63c0d22a3f80cfa151895b840ec94c7
Cr-Commit-Position: refs/heads/master@{#408611}