Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: gpu/command_buffer/service/framebuffer_manager.cc

Issue 2190543005: Command buffer: feedback loop detection for CopyTexSubImage3D (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix bot failure: split tests, previous calls to CopyTexSubImage3D may make framebuffer incomplete Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/framebuffer_manager.h" 5 #include "gpu/command_buffer/service/framebuffer_manager.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 return renderbuffer_->GetSignatureSize(); 129 return renderbuffer_->GetSignatureSize();
130 } 130 }
131 131
132 void AddToSignature(TextureManager* texture_manager, 132 void AddToSignature(TextureManager* texture_manager,
133 std::string* signature) const override { 133 std::string* signature) const override {
134 DCHECK(signature); 134 DCHECK(signature);
135 renderbuffer_->AddToSignature(signature); 135 renderbuffer_->AddToSignature(signature);
136 } 136 }
137 137
138 bool FormsFeedbackLoop(TextureRef* /* texture */, 138 bool FormsFeedbackLoop(TextureRef* /* texture */,
139 GLint /*level */) const override { 139 GLint /* level */,
140 GLint /* layer */) const override {
140 return false; 141 return false;
141 } 142 }
142 143
143 bool EmulatingRGB() const override { return false; } 144 bool EmulatingRGB() const override { return false; }
144 145
145 protected: 146 protected:
146 ~RenderbufferAttachment() override {} 147 ~RenderbufferAttachment() override {}
147 148
148 private: 149 private:
149 scoped_refptr<Renderbuffer> renderbuffer_; 150 scoped_refptr<Renderbuffer> renderbuffer_;
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
299 return texture_manager->GetSignatureSize(); 300 return texture_manager->GetSignatureSize();
300 } 301 }
301 302
302 void AddToSignature(TextureManager* texture_manager, 303 void AddToSignature(TextureManager* texture_manager,
303 std::string* signature) const override { 304 std::string* signature) const override {
304 DCHECK(signature); 305 DCHECK(signature);
305 texture_manager->AddToSignature( 306 texture_manager->AddToSignature(
306 texture_ref_.get(), target_, level_, signature); 307 texture_ref_.get(), target_, level_, signature);
307 } 308 }
308 309
309 bool FormsFeedbackLoop(TextureRef* texture, GLint level) const override { 310 bool FormsFeedbackLoop(TextureRef* texture,
310 return texture == texture_ref_.get() && level == level_; 311 GLint level, GLint layer) const override {
312 return texture == texture_ref_.get() &&
313 level == level_ && layer == layer_;
311 } 314 }
312 315
313 bool EmulatingRGB() const override { 316 bool EmulatingRGB() const override {
314 return texture_ref_->texture()->EmulatingRGB(); 317 return texture_ref_->texture()->EmulatingRGB();
315 } 318 }
316 319
317 protected: 320 protected:
318 ~TextureAttachment() override {} 321 ~TextureAttachment() override {}
319 322
320 private: 323 private:
(...skipping 757 matching lines...) Expand 10 before | Expand all | Expand 10 after
1078 1081
1079 bool FramebufferManager::IsComplete( 1082 bool FramebufferManager::IsComplete(
1080 Framebuffer* framebuffer) { 1083 Framebuffer* framebuffer) {
1081 DCHECK(framebuffer); 1084 DCHECK(framebuffer);
1082 return framebuffer->framebuffer_complete_state_count_id() == 1085 return framebuffer->framebuffer_complete_state_count_id() ==
1083 framebuffer_state_change_count_; 1086 framebuffer_state_change_count_;
1084 } 1087 }
1085 1088
1086 } // namespace gles2 1089 } // namespace gles2
1087 } // namespace gpu 1090 } // namespace gpu
OLDNEW
« no previous file with comments | « gpu/command_buffer/service/framebuffer_manager.h ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698