Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: gpu/command_buffer/service/framebuffer_manager.cc

Issue 2190543005: Command buffer: feedback loop detection for CopyTexSubImage3D (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix bot failure: split tests, previous calls to CopyTexSubImage3D may make framebuffer incomplete Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/framebuffer_manager.h ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/framebuffer_manager.cc
diff --git a/gpu/command_buffer/service/framebuffer_manager.cc b/gpu/command_buffer/service/framebuffer_manager.cc
index cce15a22b536d25281986b38176f3381db39a7b8..6f272008112c9eef7a9039b82ca0fafb9e3f9552 100644
--- a/gpu/command_buffer/service/framebuffer_manager.cc
+++ b/gpu/command_buffer/service/framebuffer_manager.cc
@@ -136,7 +136,8 @@ class RenderbufferAttachment
}
bool FormsFeedbackLoop(TextureRef* /* texture */,
- GLint /*level */) const override {
+ GLint /* level */,
+ GLint /* layer */) const override {
return false;
}
@@ -306,8 +307,10 @@ class TextureAttachment
texture_ref_.get(), target_, level_, signature);
}
- bool FormsFeedbackLoop(TextureRef* texture, GLint level) const override {
- return texture == texture_ref_.get() && level == level_;
+ bool FormsFeedbackLoop(TextureRef* texture,
+ GLint level, GLint layer) const override {
+ return texture == texture_ref_.get() &&
+ level == level_ && layer == layer_;
}
bool EmulatingRGB() const override {
« no previous file with comments | « gpu/command_buffer/service/framebuffer_manager.h ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698