gpu/command_buffer/service/framebuffer_manager.h - Issue 2190543005: Command buffer: feedback loop detection for CopyTexSubImage3D

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/framebuffer_manager.h

Issue 2190543005: Command buffer: feedback loop detection for CopyTexSubImage3D (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bot failure: split tests, previous calls to CopyTexSubImage3D may make framebuffer incomplete Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gpu/command_buffer/service/framebuffer_manager.h

diff --git a/gpu/command_buffer/service/framebuffer_manager.h b/gpu/command_buffer/service/framebuffer_manager.h

index 4e964104142579e92a654f61ec30415e80454447..b5de696c4c1394db806c3dda79823f3256dae131 100644

--- a/gpu/command_buffer/service/framebuffer_manager.h

+++ b/gpu/command_buffer/service/framebuffer_manager.h

@@ -68,7 +68,8 @@ class GPU_EXPORT Framebuffer : public base::RefCounted<Framebuffer> {

virtual size_t GetSignatureSize(TextureManager* texture_manager) const = 0;

virtual void AddToSignature(

TextureManager* texture_manager, std::string* signature) const = 0;

- virtual bool FormsFeedbackLoop(TextureRef* texture, GLint level) const = 0;

+ virtual bool FormsFeedbackLoop(

+ TextureRef* texture, GLint level, GLint layer) const = 0;

virtual bool EmulatingRGB() const = 0;

protected:

« no previous file with comments | « no previous file | gpu/command_buffer/service/framebuffer_manager.cc » ('j') | no next file with comments »