Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2190353003: Delete old Ozone surface creation API. (Closed)

Created:
4 years, 4 months ago by kylechar
Modified:
4 years, 4 months ago
Reviewers:
no sievers, spang
CC:
chromium-reviews, kalyank, piman+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete old Ozone surface creation API. This CL deletes the remainder of the old Ozone surface API. All Ozone platforms have been switched over to the new API and directly create GLSurfaces. Remove SurfaceOzoneEGL, GLSurfaceOzoneEGL and some helper methods. The SwapCompletionCallback typedef from SurfaceOzoneEGL is moved to it's own file so it can still be used. This essentially finishes the refactor in the associated bug. BUG=611142 Committed: https://crrev.com/01a32f17f8bf3ddf8c2a523ea30a44ba21418453 Cr-Commit-Position: refs/heads/master@{#409872}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -460 lines) Patch
M ui/gl/init/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gl/init/gl_factory_ozone.cc View 1 5 chunks +1 line, -40 lines 0 comments Download
M ui/gl/init/gl_init.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/gl/init/gl_surface_ozone.h View 1 chunk +0 lines, -25 lines 0 comments Download
D ui/gl/init/gl_surface_ozone.cc View 1 chunk +0 lines, -194 lines 0 comments Download
M ui/ozone/BUILD.gn View 1 1 chunk +1 line, -2 lines 0 comments Download
M ui/ozone/common/egl_util.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ui/ozone/common/egl_util.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M ui/ozone/ozone.gyp View 1 chunk +1 line, -2 lines 0 comments Download
M ui/ozone/platform/cast/surface_factory_cast.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/cast/surface_factory_cast.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_thread.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/drm_window.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/drm_window_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_surface_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_surface_factory.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/ozone/platform/drm/gpu/page_flip_request.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/wayland/wayland_surface_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/x11/x11_surface_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/x11/x11_surface_factory.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/ozone/public/surface_factory_ozone.h View 4 chunks +3 lines, -20 lines 0 comments Download
M ui/ozone/public/surface_factory_ozone.cc View 2 chunks +2 lines, -20 lines 0 comments Download
D ui/ozone/public/surface_ozone_egl.h View 1 chunk +0 lines, -85 lines 0 comments Download
D ui/ozone/public/surface_ozone_egl.cc View 1 chunk +0 lines, -20 lines 0 comments Download
A ui/ozone/public/swap_completion_callback.h View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
kylechar
I'll sit on this until next week to see if any problems crop up from ...
4 years, 4 months ago (2016-07-29 19:17:46 UTC) #6
spang
lgtm
4 years, 4 months ago (2016-08-02 14:12:08 UTC) #7
kylechar
+sievers for ui/gl/init/BUILD.gn.
4 years, 4 months ago (2016-08-04 15:14:29 UTC) #11
no sievers
On 2016/08/04 15:14:29, kylechar wrote: > +sievers for ui/gl/init/BUILD.gn. lgtm
4 years, 4 months ago (2016-08-04 17:51:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190353003/20001
4 years, 4 months ago (2016-08-04 17:58:14 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-04 19:47:04 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 19:48:42 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/01a32f17f8bf3ddf8c2a523ea30a44ba21418453
Cr-Commit-Position: refs/heads/master@{#409872}

Powered by Google App Engine
This is Rietveld 408576698