Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1551)

Unified Diff: ui/ozone/public/surface_factory_ozone.h

Issue 2190353003: Delete old Ozone surface creation API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/ozone/platform/x11/x11_surface_factory.cc ('k') | ui/ozone/public/surface_factory_ozone.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/ozone/public/surface_factory_ozone.h
diff --git a/ui/ozone/public/surface_factory_ozone.h b/ui/ozone/public/surface_factory_ozone.h
index 0522b45bdf049ec77346c1e1d8f6dc77c6b934af..de8d5bd40679309c4db03980cae31887cf76164d 100644
--- a/ui/ozone/public/surface_factory_ozone.h
+++ b/ui/ozone/public/surface_factory_ozone.h
@@ -27,7 +27,6 @@ namespace ui {
class NativePixmap;
class SurfaceOzoneCanvas;
-class SurfaceOzoneEGL;
// The Ozone interface allows external implementations to hook into Chromium to
// provide a system specific implementation. The Ozone interface supports two
@@ -71,10 +70,6 @@ class OZONE_BASE_EXPORT SurfaceFactoryOzone {
// display connection for the native display.
virtual intptr_t GetNativeDisplay();
- // Checks if platform uses the new surface creation API.
- // TODO(kylechar): Delete when using all implementations use new surface API.
- virtual bool UseNewSurfaceAPI();
-
// Creates a GL surface that renders directly to a view for the specified GL
// implementation.
virtual scoped_refptr<gl::GLSurface> CreateViewGLSurface(
@@ -82,7 +77,9 @@ class OZONE_BASE_EXPORT SurfaceFactoryOzone {
gfx::AcceleratedWidget widget);
// Creates a GL surface that renders directly into a window with surfaceless
- // semantics for the specified GL implementation.
+ // semantics for the specified GL implementation. The surface is not backed
+ // by any buffers and is used for overlay-only displays. This will return
+ // nullptr if surfaceless mode unsupported.
virtual scoped_refptr<gl::GLSurface> CreateSurfacelessViewGLSurface(
gl::GLImplementation implementation,
gfx::AcceleratedWidget widget);
@@ -93,20 +90,6 @@ class OZONE_BASE_EXPORT SurfaceFactoryOzone {
gl::GLImplementation implementation,
const gfx::Size& size);
- // Create SurfaceOzoneEGL for the specified gfx::AcceleratedWidget.
- //
- // Note: When used from content, this is called in the GPU process. The
- // platform must support creation of SurfaceOzoneEGL from the GPU process
- // using only the handle contained in gfx::AcceleratedWidget.
- virtual std::unique_ptr<SurfaceOzoneEGL> CreateEGLSurfaceForWidget(
- gfx::AcceleratedWidget widget);
-
- // Create an EGL surface that isn't backed by any buffers, and is used
- // for overlay-only displays. This will return NULL if this mode is
- // not supported.
- virtual std::unique_ptr<SurfaceOzoneEGL> CreateSurfacelessEGLSurfaceForWidget(
- gfx::AcceleratedWidget widget);
-
// Create SurfaceOzoneCanvas for the specified gfx::AcceleratedWidget.
//
// Note: The platform must support creation of SurfaceOzoneCanvas from the
« no previous file with comments | « ui/ozone/platform/x11/x11_surface_factory.cc ('k') | ui/ozone/public/surface_factory_ozone.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698