Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 218813002: Revert 170357 "Revert of Make DOMWrapperWorld::current() return ..." (Closed)

Created:
6 years, 8 months ago by haraken
Modified:
6 years, 8 months ago
Reviewers:
enne (OOO)
CC:
blink-reviews
Visibility:
Public.

Description

Revert 170357 "Revert of Make DOMWrapperWorld::current() return ..." This is a revert of the revert of r170261. r170261 was reverted because it introduced new memory leaks, but the leaks were false-positive. > Revert of Make DOMWrapperWorld::current() return a reference instead of a pointer (https://codereview.chromium.org/209713003/) > > Also reverting dependent patch https://codereview.chromium.org/213543004 > > Reason for revert: > Likely to have caused memory leaks: > http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Tests%20%282%29/builds/989/steps/browser_tests/logs/stdio#failure1 > > (1) > Direct leak of 32 byte(s) in 1 object(s) allocated from: > #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62 > #1 0x9bdfd8a in WebCore::V8PerContextDataHolder::install(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:56 > #2 0x9bdfa06 in WebCore::V8PerContextData::V8PerContextData(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:108 > #3 0x9bc1afd in WebCore::V8PerContextData::create(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.h:66:16 > #4 0x9be64fc in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132 > > (2) > Indirect leak of 40 byte(s) in 1 object(s) allocated from: > #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62 > #1 0x9b2ee18 in operator new third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:59:22 > #2 0x9b2ee18 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53 > #3 0x9be64e7 in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132 > > (3) > Indirect leak of 24 byte(s) in 1 object(s) allocated from: > #0 0x4b46c1 in __interceptor_malloc /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:75 > #1 0x62caf0a in partitionAllocGenericFlags third_party/WebKit/Source/wtf/PartitionAlloc.h:533 > #2 0x62caf0a in partitionAllocGeneric third_party/WebKit/Source/wtf/PartitionAlloc.h:549 > #3 0x62caf0a in WTF::fastMalloc(unsigned long) third_party/WebKit/Source/wtf/FastMalloc.cpp:125 > #4 0x9b2ed61 in operator new third_party/WebKit/Source/wtf/RefCounted.h:175 > #5 0x9b2ed61 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53 > > Original issue's description: > > Make DOMWrapperWorld::current() return a reference instead of a pointer > > > > Now that it's guaranteed that DOMWrapperWorld is not 0 at any given time, we can make it a reference instead of a pointer. > > > > BUG=341032 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170261 > > TBR=jochen@chromium.org,dcarney@chromium.org,abarth@chromium.org,haraken@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=341032 > > Review URL: https://codereview.chromium.org/217053007 TBR=enne@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170424

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6322 lines, -17176 lines) Patch
M trunk/Source/bindings/templates/callback_interface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/templates/interface.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/templates/interface.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M trunk/Source/bindings/tests/idls/SVGTestInterface.idl View 1 chunk +1 line, -1 line 0 comments Download
D trunk/Source/bindings/tests/idls/TestEventTarget.idl View 1 chunk +0 lines, -37 lines 0 comments Download
M trunk/Source/bindings/tests/idls/TestImplements.idl View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/tests/idls/TestImplements2.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/Source/bindings/tests/idls/TestImplements3.idl View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/tests/idls/TestInterface.idl View 1 chunk +59 lines, -31 lines 0 comments Download
A + trunk/Source/bindings/tests/idls/TestInterface2.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/bindings/tests/idls/TestInterface3.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/Source/bindings/tests/idls/TestInterfaceDoNotCheckConstants.idl View 1 chunk +0 lines, -36 lines 0 comments Download
D trunk/Source/bindings/tests/idls/TestInterfacePython.idl View 1 chunk +0 lines, -53 lines 0 comments Download
D trunk/Source/bindings/tests/idls/TestInterfacePython2.idl View 1 chunk +0 lines, -42 lines 0 comments Download
D trunk/Source/bindings/tests/idls/TestInterfacePython3.idl View 1 chunk +0 lines, -38 lines 0 comments Download
M trunk/Source/bindings/tests/idls/TestObject.idl View 1 chunk +434 lines, -275 lines 0 comments Download
D trunk/Source/bindings/tests/idls/TestObjectPython.idl View 1 chunk +0 lines, -458 lines 0 comments Download
M trunk/Source/bindings/tests/idls/TestPartialInterface.idl View 1 chunk +43 lines, -36 lines 0 comments Download
A + trunk/Source/bindings/tests/idls/TestPartialInterface2.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/Source/bindings/tests/idls/TestPartialInterfacePython.idl View 1 chunk +0 lines, -57 lines 0 comments Download
D trunk/Source/bindings/tests/idls/TestPartialInterfacePython2.idl View 1 chunk +0 lines, -42 lines 0 comments Download
A + trunk/Source/bindings/tests/idls/TestSpecialOperations.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/Source/bindings/tests/idls/TestSpecialOperationsAnonymous.idl View 1 chunk +0 lines, -41 lines 0 comments Download
D trunk/Source/bindings/tests/idls/TestSpecialOperationsCustom.idl View 1 chunk +0 lines, -36 lines 0 comments Download
D trunk/Source/bindings/tests/idls/TestSpecialOperationsIdentifierRaisesException.idl View 1 chunk +0 lines, -41 lines 0 comments Download
D trunk/Source/bindings/tests/idls/TestSpecialOperationsInt.idl View 1 chunk +0 lines, -11 lines 0 comments Download
D trunk/Source/bindings/tests/idls/TestSpecialOperationsOverrideBuiltins.idl View 1 chunk +0 lines, -10 lines 0 comments Download
M trunk/Source/bindings/tests/idls/TestTypedefs.idl View 2 chunks +13 lines, -18 lines 0 comments Download
M trunk/Source/bindings/tests/results/V8SVGTestInterface.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/tests/results/V8TestCallbackInterface.cpp View 10 chunks +10 lines, -10 lines 0 comments Download
D trunk/Source/bindings/tests/results/V8TestEventTarget.h View 1 chunk +0 lines, -132 lines 0 comments Download
D trunk/Source/bindings/tests/results/V8TestEventTarget.cpp View 1 chunk +0 lines, -335 lines 0 comments Download
M trunk/Source/bindings/tests/results/V8TestException.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/tests/results/V8TestInterface.h View 2 chunks +27 lines, -68 lines 0 comments Download
M trunk/Source/bindings/tests/results/V8TestInterface.cpp View 26 chunks +802 lines, -321 lines 0 comments Download
A + trunk/Source/bindings/tests/results/V8TestInterface2.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/bindings/tests/results/V8TestInterface2.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/bindings/tests/results/V8TestInterface3.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/bindings/tests/results/V8TestInterface3.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/Source/bindings/tests/results/V8TestInterfaceCheckSecurity.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/tests/results/V8TestInterfaceConstructor.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/tests/results/V8TestInterfaceConstructor2.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/tests/results/V8TestInterfaceConstructor3.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/tests/results/V8TestInterfaceCustomConstructor.h View 1 chunk +1 line, -1 line 0 comments Download
D trunk/Source/bindings/tests/results/V8TestInterfaceDoNotCheckConstants.h View 1 chunk +0 lines, -129 lines 0 comments Download
D trunk/Source/bindings/tests/results/V8TestInterfaceDoNotCheckConstants.cpp View 1 chunk +0 lines, -129 lines 0 comments Download
M trunk/Source/bindings/tests/results/V8TestInterfaceDocument.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/tests/results/V8TestInterfaceDocument.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/Source/bindings/tests/results/V8TestInterfaceEmpty.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/tests/results/V8TestInterfaceEventConstructor.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/tests/results/V8TestInterfaceEventTarget.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/tests/results/V8TestInterfaceNamedConstructor.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/tests/results/V8TestInterfaceNode.h View 1 chunk +1 line, -1 line 0 comments Download
D trunk/Source/bindings/tests/results/V8TestInterfacePython.h View 1 chunk +0 lines, -98 lines 0 comments Download
D trunk/Source/bindings/tests/results/V8TestInterfacePython.cpp View 1 chunk +0 lines, -1223 lines 0 comments Download
D trunk/Source/bindings/tests/results/V8TestInterfacePython2.h View 1 chunk +0 lines, -126 lines 0 comments Download
D trunk/Source/bindings/tests/results/V8TestInterfacePython2.cpp View 1 chunk +0 lines, -179 lines 0 comments Download
D trunk/Source/bindings/tests/results/V8TestInterfacePython3.h View 1 chunk +0 lines, -130 lines 0 comments Download
D trunk/Source/bindings/tests/results/V8TestInterfacePython3.cpp View 1 chunk +0 lines, -124 lines 0 comments Download
M trunk/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/tests/results/V8TestNode.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/tests/results/V8TestObject.h View 3 chunks +23 lines, -12 lines 0 comments Download
M trunk/Source/bindings/tests/results/V8TestObject.cpp View 17 chunks +4739 lines, -2336 lines 0 comments Download
D trunk/Source/bindings/tests/results/V8TestObjectPython.h View 1 chunk +0 lines, -148 lines 0 comments Download
D trunk/Source/bindings/tests/results/V8TestObjectPython.cpp View 1 chunk +0 lines, -8048 lines 0 comments Download
A + trunk/Source/bindings/tests/results/V8TestSpecialOperations.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/bindings/tests/results/V8TestSpecialOperations.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/Source/bindings/tests/results/V8TestSpecialOperationsAnonymous.h View 1 chunk +0 lines, -129 lines 0 comments Download
D trunk/Source/bindings/tests/results/V8TestSpecialOperationsAnonymous.cpp View 1 chunk +0 lines, -278 lines 0 comments Download
D trunk/Source/bindings/tests/results/V8TestSpecialOperationsCustom.h View 1 chunk +0 lines, -137 lines 0 comments Download
D trunk/Source/bindings/tests/results/V8TestSpecialOperationsCustom.cpp View 1 chunk +0 lines, -183 lines 0 comments Download
D trunk/Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.h View 1 chunk +0 lines, -129 lines 0 comments Download
D trunk/Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp View 1 chunk +0 lines, -449 lines 0 comments Download
D trunk/Source/bindings/tests/results/V8TestSpecialOperationsInt.h View 1 chunk +0 lines, -129 lines 0 comments Download
D trunk/Source/bindings/tests/results/V8TestSpecialOperationsInt.cpp View 1 chunk +0 lines, -250 lines 0 comments Download
M trunk/Source/bindings/tests/results/V8TestSpecialOperationsNotEnumerable.h View 1 chunk +1 line, -1 line 0 comments Download
D trunk/Source/bindings/tests/results/V8TestSpecialOperationsOverrideBuiltins.h View 1 chunk +0 lines, -129 lines 0 comments Download
D trunk/Source/bindings/tests/results/V8TestSpecialOperationsOverrideBuiltins.cpp View 1 chunk +0 lines, -203 lines 0 comments Download
M trunk/Source/bindings/tests/results/V8TestTypedefs.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/tests/results/V8TestTypedefs.cpp View 5 chunks +58 lines, -229 lines 0 comments Download
M trunk/Source/bindings/v8/CustomElementConstructorBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/v8/CustomElementWrapper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/v8/DOMDataStore.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/bindings/v8/DOMDataStore.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/v8/DOMRequestState.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/v8/DOMWrapperWorld.h View 1 chunk +4 lines, -5 lines 0 comments Download
M trunk/Source/bindings/v8/DOMWrapperWorld.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/Source/bindings/v8/MIDIAccessResolver.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/bindings/v8/ScriptController.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/Source/bindings/v8/ScriptController.cpp View 4 chunks +11 lines, -15 lines 0 comments Download
M trunk/Source/bindings/v8/ScriptPreprocessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/v8/SerializedScriptValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/v8/V8AbstractEventListener.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/Source/bindings/v8/V8AbstractEventListener.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/bindings/v8/V8Binding.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/Source/bindings/v8/V8Binding.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M trunk/Source/bindings/v8/V8DOMConfiguration.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/v8/V8DOMConfiguration.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/bindings/v8/V8ErrorHandler.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/bindings/v8/V8Initializer.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M trunk/Source/bindings/v8/V8MutationCallback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/v8/V8PerContextData.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/v8/V8PerContextData.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M trunk/Source/bindings/v8/V8PerIsolateData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/v8/V8WindowShell.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/bindings/v8/V8WindowShell.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/Source/bindings/v8/WorkerScriptController.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/v8/WorkerScriptController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/Source/bindings/v8/custom/V8ArrayBufferCustom.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/v8/custom/V8CustomEventCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/v8/custom/V8MessageEventCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/v8/custom/V8TypedArrayCustom.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/Source/core/events/EventListener.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/Source/core/loader/EmptyClients.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/loader/FrameLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/loader/FrameLoader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/Source/core/loader/FrameLoaderClient.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/web/FrameLoaderClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/web/FrameLoaderClientImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/Source/web/tests/CustomEventTest.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M trunk/Tools/Scripts/webkitpy/bindings/main.py View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
haraken
6 years, 8 months ago (2014-03-31 00:35:30 UTC) #1
haraken
Committed patchset #1 manually as r170424.
6 years, 8 months ago (2014-03-31 00:37:30 UTC) #2
enne (OOO)
6 years, 8 months ago (2014-03-31 19:29:47 UTC) #3
Message was sent while issue was closed.
Thanks.  Sorry for not unreverting this myself on Friday, but there was a lot of
flailing to try to get the CQ/Chromium tree green and I forgot to come back and
do this.

Powered by Google App Engine
This is Rietveld 408576698