[ash-md] Improves smoothness with many windows in overview

[ash-md] Improves smoothness with many windows in overview

Experimentally, most of the animation cost was coming from having window
shapes (used to mask the window header) and from using rounded rectangle
masks.
This CL disables both those performance hogs when there are more than
certain number of windows in the overview mode (controlled via flags).
Default is set to hardcoded 10.
It also makes sure that window controls (minimize / resize / close) are
hidden when in overview mode for custom and panel frames.

New flags are introduced:

--ash-max-previews-to-use-mask=<number>
Maximum number of preview windows in overview mode that can use masks to
hide window headers and use rounded corners. Use -1 to set to unlimited.

--ash-max-previews-to-use-shape=<number>
Maximum number of preview windows in overview mode that can use shapes to
hide window headers. Use -1 to set to unlimited.

BUG=626851
BUG=624608
Review-Url: https://codereview.chromium.org/2146323004
Cr-Commit-Position: refs/heads/master@{#406286}
(cherry picked from commit d8748a3907d55ade9282b8cf4d0993ac9ee5ab66)

Committed: https://chromium.googlesource.com/chromium/src/+/fbfb5afbb61eac2a18e6b210ec4f40162357f612

[varkha, 2016-07-26 23:16:06]

Description was changed from

==========
[ash-md] Improves smoothness with many windows in overview

Experimentally, most of the animation cost was coming from having window
shapes (used to mask the window header) and from using rounded rectangle
masks.
This CL disables both those performance hogs when there are more than
certain number of windows in the overview mode (controlled via flags).
Default is set to hardcoded 10.
It also makes sure that window controls (minimize / resize / close) are
hidden when in overview mode for custom and panel frames.

New flags are introduced:

--ash-max-previews-to-use-mask=<number>
Maximum number of preview windows in overview mode that can use masks to
hide window headers and use rounded corners. Use -1 to set to unlimited.

--ash-max-previews-to-use-shape=<number>
Maximum number of preview windows in overview mode that can use shapes to
hide window headers. Use -1 to set to unlimited.

BUG=626851
BUG=624608

Review-Url: https://codereview.chromium.org/2146323004
Cr-Commit-Position: refs/heads/master@{#406286}
(cherry picked from commit d8748a3907d55ade9282b8cf4d0993ac9ee5ab66)
==========

to

==========
[ash-md] Improves smoothness with many windows in overview

Experimentally, most of the animation cost was coming from having window
shapes (used to mask the window header) and from using rounded rectangle
masks.
This CL disables both those performance hogs when there are more than
certain number of windows in the overview mode (controlled via flags).
Default is set to hardcoded 10.
It also makes sure that window controls (minimize / resize / close) are
hidden when in overview mode for custom and panel frames.

New flags are introduced:

--ash-max-previews-to-use-mask=<number>
Maximum number of preview windows in overview mode that can use masks to
hide window headers and use rounded corners. Use -1 to set to unlimited.

--ash-max-previews-to-use-shape=<number>
Maximum number of preview windows in overview mode that can use shapes to
hide window headers. Use -1 to set to unlimited.

BUG=626851
BUG=624608

Review-Url: https://codereview.chromium.org/2146323004
Cr-Commit-Position: refs/heads/master@{#406286}
(cherry picked from commit d8748a3907d55ade9282b8cf4d0993ac9ee5ab66)

Committed:
https://chromium.googlesource.com/chromium/src/+/fbfb5afbb61eac2a18e6b210ec4f...
==========

[varkha, 2016-07-26 23:16:07]

Committed patchset #1 (id:1) manually as
fbfb5afbb61eac2a18e6b210ec4f40162357f612.

[Theresa, 2016-07-29 22:59:13]

On 2016/07/26 23:16:07, varkha wrote:
> Committed patchset #1 (id:1) manually as
> fbfb5afbb61eac2a18e6b210ec4f40162357f612.

This CL added // FLAGS:RECORD_UMA to enable-web-bluetooth causing presubmit to
fail on a CL I just tried to land on branch 2785 

This was the error:
ERROR:root:actions.xml is not formatted correctly; run extract_actions.py to
fix.

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

** Presubmit ERRORS **
actions.xml is not up to date or is not formatted correctly; run
extract_actions.py to fix


And the suggested fix was to add an action for <action
name="AboutFlags_enable-web-bluetooth">

The flag/action were originally added in
https://codereview.chromium.org/2096883003, which is not present on 2785

Will you please merge a CL to 2785 that adds this action? Also, if presubmit ran
when you submitted this CL and didn't complain, will you please file a bug for
that?

[varkha, 2016-07-29 23:26:22]

On 2016/07/29 22:59:13, Theresa Wellington wrote:
> On 2016/07/26 23:16:07, varkha wrote:
> > Committed patchset #1 (id:1) manually as
> > fbfb5afbb61eac2a18e6b210ec4f40162357f612.
> 
> This CL added // FLAGS:RECORD_UMA to enable-web-bluetooth causing presubmit to
> fail on a CL I just tried to land on branch 2785 
> 
> This was the error:
> ERROR:root:actions.xml is not formatted correctly; run extract_actions.py to
> fix.
> 
> ** Presubmit Messages **
> --tbr was specified, skipping OWNERS check
> 
> ** Presubmit ERRORS **
> actions.xml is not up to date or is not formatted correctly; run
> extract_actions.py to fix
> 
> 
> And the suggested fix was to add an action for <action
> name="AboutFlags_enable-web-bluetooth">
> 
> The flag/action were originally added in
> https://codereview.chromium.org/2096883003, which is not present on 2785
> 
> Will you please merge a CL to 2785 that adds this action? Also, if presubmit
ran
> when you submitted this CL and didn't complain, will you please file a bug for
> that?

Do I understand it correctly that you need to remove the // FLAGS:RECORD_UMA
comment added from merge in about_flags.cc? Is that the only thing? Used drover
to land this so I guess presubmit did not run.