Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 2096883003: bluetooth: Enable UMA tracking of --enable-web-bluetooth flag (Closed)

Created:
4 years, 6 months ago by François Beaufort
Modified:
4 years, 5 months ago
Reviewers:
scheib, ortuno, rkaplow
CC:
asvitkine+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Enable UMA tracking of --enable-web-bluetooth flag Committed: https://crrev.com/f23214897b2c3674808544906b6cc7eb49ca9d25 Cr-Commit-Position: refs/heads/master@{#403703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/browser/about_flags.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tools/metrics/actions/actions.xml View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
François Beaufort
Hello Gio, In the same vein as crbug.com/622495, I think this would be valuable for ...
4 years, 6 months ago (2016-06-24 07:55:46 UTC) #3
ortuno
As mentioned offline we already histogram usage of the --enable-web-bluetooth flag.
4 years, 6 months ago (2016-06-24 16:03:05 UTC) #4
ortuno
scheib: can you take a look at this?
4 years, 6 months ago (2016-06-24 20:37:49 UTC) #6
François Beaufort
On 2016/06/24 20:37:49, ortuno wrote: > scheib: can you take a look at this? FYI, ...
4 years, 5 months ago (2016-06-27 12:05:05 UTC) #7
François Beaufort
On 2016/06/27 12:05:05, François Beaufort wrote: > On 2016/06/24 20:37:49, ortuno wrote: > > scheib: ...
4 years, 5 months ago (2016-06-30 14:10:15 UTC) #8
scheib
LGTM
4 years, 5 months ago (2016-06-30 22:29:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096883003/1
4 years, 5 months ago (2016-07-01 03:45:03 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/211135)
4 years, 5 months ago (2016-07-01 03:54:40 UTC) #13
François Beaufort
rkaplow, please can you review changes in tools/metrics/actions/actions.xml Thank you!
4 years, 5 months ago (2016-07-01 04:01:53 UTC) #15
rkaplow
lgtm
4 years, 5 months ago (2016-07-04 14:45:38 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096883003/1
4 years, 5 months ago (2016-07-04 16:44:53 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-04 18:15:11 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 18:18:21 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f23214897b2c3674808544906b6cc7eb49ca9d25
Cr-Commit-Position: refs/heads/master@{#403703}

Powered by Google App Engine
This is Rietveld 408576698