[ash-md] Improves smoothness with many windows in overview

[ash-md] Improves smoothness with many windows in overview

Experimentally, most of the animation cost was coming from having window
shapes (used to mask the window header) and from using rounded rectangle
masks.
This CL disables both those performance hogs when there are more than
certain number of windows in the overview mode (controlled via flags).
Default is set to hardcoded 10.
It also makes sure that window controls (minimize / resize / close) are
hidden when in overview mode for custom and panel frames.

New flags are introduced:

--ash-max-previews-to-use-mask=<number>
Maximum number of preview windows in overview mode that can use masks to
hide window headers and use rounded corners. Use -1 to set to unlimited.

--ash-max-previews-to-use-shape=<number>
Maximum number of preview windows in overview mode that can use shapes to
hide window headers. Use -1 to set to unlimited.

BUG=626851
BUG=624608
Committed: https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66
Cr-Commit-Position: refs/heads/master@{#406286}

[varkha, 2016-07-15 01:40:07]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 01:40:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2016-07-15 01:45:07]

Description was changed from

==========
[ash-md] Improves smoothness with many windows in overview

Experimentally, most of the animation cost was coming from having window
shapes (used to mask the window header) and from using rounded rectangle
masks.
This CL disables both those performance hogs when there are more than
10 windows in animation.
It also maks sure that window controls (minimize / resize / close) are
hidden when in overview mode for custom and panel frames.

BUG=626851
==========

to

==========
[ash-md] Improves smoothness with many windows in overview

Experimentally, most of the animation cost was coming from having window
shapes (used to mask the window header) and from using rounded rectangle
masks.
This CL disables both those performance hogs when there are more than
10 windows in animation.
It also maks sure that window controls (minimize / resize / close) are
hidden when in overview mode for custom and panel frames.

BUG=626851
BUG=624608
==========

[varkha, 2016-07-15 01:51:09]

varkha@chromium.org changed reviewers:
+ oshima@chromium.org, tdanderson@chromium.org

[varkha, 2016-07-15 01:51:10]

tdanderson@, can you please take a first look when you are back.

oshima@, can you take a look for OWNERS in ash/frame/custom_frame_view_ash.cc?
That part is doing the same window controls visibility flip as the current code
in
https://cs.chromium.org/chromium/src/chrome/browser/ui/views/frame/browser_no...

Thanks!

[commit-bot: I haz the power, 2016-07-15 02:20:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 02:20:34]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-07-15 23:37:48]

can you explain why caption controls are causing the performance issue?

[varkha, 2016-07-16 01:13:25]

On 2016/07/15 23:37:48, oshima wrote:
> can you explain why caption controls are causing the performance issue?

It is not the caption controls but rather the mask and shape that is installed
on the window layer when it is transformed in overview. The mask layer is used
to have rounded corners and the SetAlphaShape() is used to mask the original
window header (I was hoping that it is less expensive than the mask layer and so
coded it for the header hiding which is more essential than the rounded
corners). Not easy to quantify but I wanted to add an experimental flag (in this
CL) to replace the kMaxWindowsCountToHideHeader constant and experiment a bit on
a few devices.

[tdanderson, 2016-07-18 16:26:58]

lgtm with one suggestion and a couple of nits

https://chromiumcodereview.appspot.com/2146323004/diff/20001/ash/common/wm/ov...
File ash/common/wm/overview/scoped_transform_overview_window.h (right):

https://chromiumcodereview.appspot.com/2146323004/diff/20001/ash/common/wm/ov...
ash/common/wm/overview/scoped_transform_overview_window.h:108: // using rounded
corners of |radius|. When |use_masks| is set hides the
nit: "is set," (comma)

https://chromiumcodereview.appspot.com/2146323004/diff/20001/ash/common/wm/ov...
File ash/common/wm/overview/window_grid.cc (right):

https://chromiumcodereview.appspot.com/2146323004/diff/20001/ash/common/wm/ov...
ash/common/wm/overview/window_grid.cc:100: // Hiding windows headers can be
resource intensive. Only hide the headers when
nit: windows->window

https://chromiumcodereview.appspot.com/2146323004/diff/20001/ash/common/wm/ov...
File ash/common/wm/overview/window_selector_item.cc (right):

https://chromiumcodereview.appspot.com/2146323004/diff/20001/ash/common/wm/ov...
ash/common/wm/overview/window_selector_item.cc:284: hide_header_(false),
IIUC at any point in time, either all of the WindowSelectorItems should show
their header or all WSIs should hide their header. Rather than tracking
|hide_header_| on a per-window basis, perhaps this member should:

* Be static in WSI, or
* Be removed altogether and replaced with something like bool
WindowHeadersVisible() { return num_windows <= 10; } in WindowSelector or
WindowGrid, and queried when needed from WSI.

[oshima, 2016-07-18 22:07:08]

lgtm

[varkha, 2016-07-19 00:23:10]

Patchset #3 (id:40001) has been deleted

[varkha, 2016-07-19 00:23:22]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 00:24:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2016-07-19 00:28:10]

The CQ bit was unchecked by varkha@chromium.org

[varkha, 2016-07-19 00:28:55]

Patchset #3 (id:60001) has been deleted

[varkha, 2016-07-19 00:29:07]

https://codereview.chromium.org/2146323004/diff/20001/ash/common/wm/overview/...
File ash/common/wm/overview/scoped_transform_overview_window.h (right):

https://codereview.chromium.org/2146323004/diff/20001/ash/common/wm/overview/...
ash/common/wm/overview/scoped_transform_overview_window.h:108: // using rounded
corners of |radius|. When |use_masks| is set hides the
On 2016/07/18 16:26:57, tdanderson wrote:
> nit: "is set," (comma)

Done.

https://codereview.chromium.org/2146323004/diff/20001/ash/common/wm/overview/...
File ash/common/wm/overview/window_grid.cc (right):

https://codereview.chromium.org/2146323004/diff/20001/ash/common/wm/overview/...
ash/common/wm/overview/window_grid.cc:100: // Hiding windows headers can be
resource intensive. Only hide the headers when
On 2016/07/18 16:26:58, tdanderson wrote:
> nit: windows->window

Done.

https://codereview.chromium.org/2146323004/diff/20001/ash/common/wm/overview/...
File ash/common/wm/overview/window_selector_item.cc (right):

https://codereview.chromium.org/2146323004/diff/20001/ash/common/wm/overview/...
ash/common/wm/overview/window_selector_item.cc:284: hide_header_(false),
On 2016/07/18 16:26:58, tdanderson wrote:
> IIUC at any point in time, either all of the WindowSelectorItems should show
> their header or all WSIs should hide their header. Rather than tracking
> |hide_header_| on a per-window basis, perhaps this member should:
> 
> * Be static in WSI, or
> * Be removed altogether and replaced with something like bool
> WindowHeadersVisible() { return num_windows <= 10; } in WindowSelector or
> WindowGrid, and queried when needed from WSI.

Done (made static and controlled by flags).

[varkha, 2016-07-19 00:29:17]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 00:30:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2016-07-19 00:49:08]

Description was changed from

==========
[ash-md] Improves smoothness with many windows in overview

Experimentally, most of the animation cost was coming from having window
shapes (used to mask the window header) and from using rounded rectangle
masks.
This CL disables both those performance hogs when there are more than
10 windows in animation.
It also maks sure that window controls (minimize / resize / close) are
hidden when in overview mode for custom and panel frames.

BUG=626851
BUG=624608
==========

to

==========
[ash-md] Improves smoothness with many windows in overview

Experimentally, most of the animation cost was coming from having window
shapes (used to mask the window header) and from using rounded rectangle
masks.
This CL disables both those performance hogs when there are more than
certain number of windows in the overview mode (controlled via flags).
Default is set to hardcoded 10.
It also makes sure that window controls (minimize / resize / close) are
hidden when in overview mode for custom and panel frames.

New flags are introduced:

--ash-max-previews-to-use-mask=<number>
Maximum number of preview windows in overview mode that can use masks to
hide window headers and use rounded corners. Use -1 to set to unlimited.

--ash-max-previews-to-use-shape=<number>
Maximum number of preview windows in overview mode that can use shapes to
hide window headers. Use -1 to set to unlimited.

BUG=626851
BUG=624608
==========

[varkha, 2016-07-19 00:53:40]

Patchset #3 (id:80001) has been deleted

[varkha, 2016-07-19 00:53:50]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 00:54:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2016-07-19 00:55:03]

varkha@chromium.org changed reviewers:
+ rkaplow@chromium.org

[varkha, 2016-07-19 00:55:04]

+rkaplow@ for OWNERS. Added flags in tools/metrics/histograms/histograms.xml.

[commit-bot: I haz the power, 2016-07-19 02:28:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 02:28:13]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[varkha, 2016-07-19 13:05:04]

Patchset #3 (id:100001) has been deleted

[varkha, 2016-07-19 13:05:36]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 13:06:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 14:21:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 14:21:46]

Dry run: This issue passed the CQ dry run.

[rkaplow, 2016-07-19 15:29:44]

lgtm

[varkha, 2016-07-19 15:58:13]

The CQ bit was checked by varkha@chromium.org

[varkha, 2016-07-19 15:58:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org, oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2146323004/#ps120001
(title: "[ash-md] Improves smoothness with many windows in overview (added
flags)")

[commit-bot: I haz the power, 2016-07-19 15:58:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 16:04:00]

Description was changed from

==========
[ash-md] Improves smoothness with many windows in overview

Experimentally, most of the animation cost was coming from having window
shapes (used to mask the window header) and from using rounded rectangle
masks.
This CL disables both those performance hogs when there are more than
certain number of windows in the overview mode (controlled via flags).
Default is set to hardcoded 10.
It also makes sure that window controls (minimize / resize / close) are
hidden when in overview mode for custom and panel frames.

New flags are introduced:

--ash-max-previews-to-use-mask=<number>
Maximum number of preview windows in overview mode that can use masks to
hide window headers and use rounded corners. Use -1 to set to unlimited.

--ash-max-previews-to-use-shape=<number>
Maximum number of preview windows in overview mode that can use shapes to
hide window headers. Use -1 to set to unlimited.

BUG=626851
BUG=624608
==========

to

==========
[ash-md] Improves smoothness with many windows in overview

Experimentally, most of the animation cost was coming from having window
shapes (used to mask the window header) and from using rounded rectangle
masks.
This CL disables both those performance hogs when there are more than
certain number of windows in the overview mode (controlled via flags).
Default is set to hardcoded 10.
It also makes sure that window controls (minimize / resize / close) are
hidden when in overview mode for custom and panel frames.

New flags are introduced:

--ash-max-previews-to-use-mask=<number>
Maximum number of preview windows in overview mode that can use masks to
hide window headers and use rounded corners. Use -1 to set to unlimited.

--ash-max-previews-to-use-shape=<number>
Maximum number of preview windows in overview mode that can use shapes to
hide window headers. Use -1 to set to unlimited.

BUG=626851
BUG=624608
==========

[commit-bot: I haz the power, 2016-07-19 16:04:01]

Committed patchset #3 (id:120001)

[commit-bot: I haz the power, 2016-07-19 16:04:05]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-19 16:05:24]

Description was changed from

==========
[ash-md] Improves smoothness with many windows in overview

Experimentally, most of the animation cost was coming from having window
shapes (used to mask the window header) and from using rounded rectangle
masks.
This CL disables both those performance hogs when there are more than
certain number of windows in the overview mode (controlled via flags).
Default is set to hardcoded 10.
It also makes sure that window controls (minimize / resize / close) are
hidden when in overview mode for custom and panel frames.

New flags are introduced:

--ash-max-previews-to-use-mask=<number>
Maximum number of preview windows in overview mode that can use masks to
hide window headers and use rounded corners. Use -1 to set to unlimited.

--ash-max-previews-to-use-shape=<number>
Maximum number of preview windows in overview mode that can use shapes to
hide window headers. Use -1 to set to unlimited.

BUG=626851
BUG=624608
==========

to

==========
[ash-md] Improves smoothness with many windows in overview

Experimentally, most of the animation cost was coming from having window
shapes (used to mask the window header) and from using rounded rectangle
masks.
This CL disables both those performance hogs when there are more than
certain number of windows in the overview mode (controlled via flags).
Default is set to hardcoded 10.
It also makes sure that window controls (minimize / resize / close) are
hidden when in overview mode for custom and panel frames.

New flags are introduced:

--ash-max-previews-to-use-mask=<number>
Maximum number of preview windows in overview mode that can use masks to
hide window headers and use rounded corners. Use -1 to set to unlimited.

--ash-max-previews-to-use-shape=<number>
Maximum number of preview windows in overview mode that can use shapes to
hide window headers. Use -1 to set to unlimited.

BUG=626851
BUG=624608

Committed: https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66
Cr-Commit-Position: refs/heads/master@{#406286}
==========

[commit-bot: I haz the power, 2016-07-19 16:05:26]

Patchset 3 (id:??) landed as
https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66
Cr-Commit-Position: refs/heads/master@{#406286}