Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2184033003: Refactor browser process coordinate transformation methods (Closed)

Created:
4 years, 4 months ago by kenrb
Modified:
4 years, 4 months ago
Reviewers:
nasko, jbauman, lfg
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor browser process coordinate transformation code The current Surface-based coordinate transformation methods are only useful for transforming coordinates from a child frame's coordinate space to the root's space. More flexibility is needed for delivering MouseMove events to multiple renderer processes for the sake of MouseEnter and MouseLeave event handlers. This CL reworks the exposed methods in RenderWidgetHostViewBase and DelegatedFrameHost to provide that flexibility. BUG=632035 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/a12ade9d1326ecce585dda08a027d8061e9f06c6 Cr-Commit-Position: refs/heads/master@{#408666}

Patch Set 1 #

Total comments: 14

Patch Set 2 : nasko comments addressed #

Total comments: 13

Patch Set 3 : Added helper method to SurfaceHittest #

Total comments: 2

Patch Set 4 : Removed problematic DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -52 lines) Patch
M cc/surfaces/surface_hittest.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M cc/surfaces/surface_hittest.cc View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
M content/browser/frame_host/cross_process_frame_connector.h View 1 chunk +14 lines, -1 line 0 comments Download
M content/browser/frame_host/cross_process_frame_connector.cc View 1 2 3 chunks +44 lines, -6 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.h View 2 chunks +11 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M content/browser/renderer_host/delegated_frame_host.h View 1 1 chunk +11 lines, -3 lines 0 comments Download
M content/browser/renderer_host/delegated_frame_host.cc View 1 2 3 1 chunk +16 lines, -11 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +7 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 1 chunk +16 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +16 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 1 chunk +10 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +6 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +14 lines, -6 lines 0 comments Download

Messages

Total messages: 35 (21 generated)
kenrb
nasko: PTAL?
4 years, 4 months ago (2016-07-27 20:02:25 UTC) #8
nasko
Few comments. Overall it will be nice for someone else more familiar with coordinate transformations ...
4 years, 4 months ago (2016-07-27 22:52:13 UTC) #9
kenrb
lfg: PTAL, as someone more familiar with Surface coordinate spaces? https://codereview.chromium.org/2184033003/diff/1/content/browser/frame_host/cross_process_frame_connector.cc File content/browser/frame_host/cross_process_frame_connector.cc (right): https://codereview.chromium.org/2184033003/diff/1/content/browser/frame_host/cross_process_frame_connector.cc#newcode184 ...
4 years, 4 months ago (2016-07-28 16:24:38 UTC) #13
lfg
Code looks good, I just have 1 suggestion and one question. https://codereview.chromium.org/2184033003/diff/20001/content/browser/frame_host/cross_process_frame_connector.cc File content/browser/frame_host/cross_process_frame_connector.cc (right): ...
4 years, 4 months ago (2016-07-28 19:58:58 UTC) #16
kenrb
PTAL again. https://codereview.chromium.org/2184033003/diff/20001/content/browser/frame_host/cross_process_frame_connector.cc File content/browser/frame_host/cross_process_frame_connector.cc (right): https://codereview.chromium.org/2184033003/diff/20001/content/browser/frame_host/cross_process_frame_connector.cc#newcode143 content/browser/frame_host/cross_process_frame_connector.cc:143: surface_id); On 2016/07/28 19:58:58, lfg wrote: > ...
4 years, 4 months ago (2016-07-28 21:19:08 UTC) #18
lfg
Sorry about the indents, for some reason rietveld is adding an extra space there for ...
4 years, 4 months ago (2016-07-28 21:30:28 UTC) #20
kenrb
jbauman: PTAL for cc/surfaces?
4 years, 4 months ago (2016-07-28 22:02:05 UTC) #22
jbauman
lgtm
4 years, 4 months ago (2016-07-29 01:22:45 UTC) #25
kenrb
nasko can you have another look please?
4 years, 4 months ago (2016-07-29 13:59:40 UTC) #26
nasko
There is one test that is hitting the DCHECK you've added. Overall the CL LGTM ...
4 years, 4 months ago (2016-07-29 14:19:47 UTC) #27
kenrb
https://codereview.chromium.org/2184033003/diff/40001/content/browser/renderer_host/delegated_frame_host.cc File content/browser/renderer_host/delegated_frame_host.cc (right): https://codereview.chromium.org/2184033003/diff/40001/content/browser/renderer_host/delegated_frame_host.cc#newcode236 content/browser/renderer_host/delegated_frame_host.cc:236: DCHECK(false); On 2016/07/29 14:19:46, nasko wrote: > This DCHECK ...
4 years, 4 months ago (2016-07-29 16:20:23 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184033003/60001
4 years, 4 months ago (2016-07-29 16:23:07 UTC) #31
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-07-29 17:07:06 UTC) #33
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 17:10:14 UTC) #35
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a12ade9d1326ecce585dda08a027d8061e9f06c6
Cr-Commit-Position: refs/heads/master@{#408666}

Powered by Google App Engine
This is Rietveld 408576698