Refactor browser process coordinate transformation methods

content/browser/renderer_host/render_widget_host_view_base.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_base.h"
 
 #include "base/logging.h"
 #include "build/build_config.h"
 #include "content/browser/accessibility/browser_accessibility_manager.h"
 #include "content/browser/gpu/gpu_data_manager_impl.h"
@@ skipping 382 matching lines @@
     const gfx::Point& point) {
   return point;
 }
 
 gfx::PointF RenderWidgetHostViewBase::TransformPointToRootCoordSpaceF(
     const gfx::PointF& point) {
   return gfx::PointF(TransformPointToRootCoordSpace(
       gfx::ToRoundedPoint(point)));
 }
 
-void RenderWidgetHostViewBase::TransformPointToLocalCoordSpace(
+gfx::Point RenderWidgetHostViewBase::TransformPointToLocalCoordSpace(
     const gfx::Point& point,
-    const cc::SurfaceId& original_surface,
-    gfx::Point* transformed_point) {
-  *transformed_point = point;
+    const cc::SurfaceId& original_surface) {
+  return point;
+}
+
+gfx::Point RenderWidgetHostViewBase::TransformPointToCoordSpaceForView(
+    const gfx::Point& point,
+    RenderWidgetHostViewBase* target_view) {

[nasko, 2016/07/27 22:52:13]

target_view here should be |this|, right? Maybe add a DCHECK to ensure we don't
call it incorrectly.

[kenrb, 2016/07/28 16:24:38]

Not generally, this is really just a stub implementation to cover Android which
doesn't have any of the support for this yet. I have added a NOTREACHED() to
make this clearer.

+  return point;
 }
 
 void RenderWidgetHostViewBase::TextInputStateChanged(
     const TextInputState& text_input_state) {
 // TODO(ekaramad): Use TextInputManager code paths for IME on other platforms.
 #if defined(USE_AURA)
   if (GetTextInputManager())
     GetTextInputManager()->UpdateTextInputState(this, text_input_state);
 #endif
 }
@@ skipping 48 matching lines @@
 
 bool RenderWidgetHostViewBase::IsChildFrameForTesting() const {
   return false;
 }
 
 cc::SurfaceId RenderWidgetHostViewBase::SurfaceIdForTesting() const {
   return cc::SurfaceId();
 }
 
 }  // namespace content