Refactor browser process coordinate transformation methods

content/browser/renderer_host/render_widget_host_view_base.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 223 matching lines @@
                                  const ui::LatencyInfo& latency) {}
   virtual void ProcessMouseWheelEvent(const blink::WebMouseWheelEvent& event,
                                       const ui::LatencyInfo& latency) {}
   virtual void ProcessTouchEvent(const blink::WebTouchEvent& event,
                                  const ui::LatencyInfo& latency) {}
   virtual void ProcessGestureEvent(const blink::WebGestureEvent& event,
                                    const ui::LatencyInfo& latency) {}
 
   // Transform a point that is in the coordinate space of a Surface that is
   // embedded within the RenderWidgetHostViewBase's Surface to the
-  // coordinate space of the embedding Surface. Typically this means that a
-  // point was received from an out-of-process iframe's RenderWidget and needs
-  // to be translated to viewport coordinates for the root RWHV, in which case
-  // this method is called on the root RWHV with the out-of-process iframe's
-  // SurfaceId.
-  virtual void TransformPointToLocalCoordSpace(
+  // coordinate space of an embedding, or embedded, Surface. Typically this

[lfg, 2016/07/28 19:58:58]

Is this comment change correct here? I can see that your changes to
CrossProcessFrameConnector allows the API to be used in either direction, but
not here. My understanding is that the |original_surface| always need to be
contained in the RWHVB's surface, but not the other way around.

[kenrb, 2016/07/28 21:19:08]

Since RenderWidgetHostViewChildFrame uses CrossProcessFrameConnector's method,
it can be either embedding or embedded by original_surface.
RenderWidgetHostViewAura and Mac require it to be embedded, but they are always
the root surface so there is no need to account for the other direction.

[lfg, 2016/07/28 21:30:27]

Acknowledged.

+  // means that a point was received from an out-of-process iframe's
+  // RenderWidget and needs to be translated to viewport coordinates for the
+  // root RWHV, in which case this method is called on the root RWHV with the
+  // out-of-process iframe's SurfaceId.
+  // This does not transform points between surfaces where one does not
+  // contain the other. To transform between sibling surfaces, the point must
+  // be transformed to the root's coordinate space as an intermediate step.
+  virtual gfx::Point TransformPointToLocalCoordSpace(
       const gfx::Point& point,
-      const cc::SurfaceId& original_surface,
-      gfx::Point* transformed_point);
+      const cc::SurfaceId& original_surface);
+
+  // Transform a point that is in the coordinate space for the current
+  // RenderWidgetHostView to the coordinate space of the target_view.
+  virtual gfx::Point TransformPointToCoordSpaceForView(
+      const gfx::Point& point,
+      RenderWidgetHostViewBase* target_view);
 
   //----------------------------------------------------------------------------
   // The following methods are related to IME.
   // TODO(ekaramad): Most of the IME methods should not stay virtual after IME
   // is implemented for OOPIF. After fixing IME, mark the corresponding methods
   // non-virtual (https://crbug.com/578168).
 
   // Updates the state of the input method attached to the view.
   virtual void TextInputStateChanged(const TextInputState& text_input_state);
 
@@ skipping 207 matching lines @@
   base::ObserverList<RenderWidgetHostViewBaseObserver> observers_;
 
   base::WeakPtrFactory<RenderWidgetHostViewBase> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewBase);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_