content/browser/renderer_host/render_widget_host_view_mac.h - Issue 2184033003: Refactor browser process coordinate transformation methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.h

Issue 2184033003: Refactor browser process coordinate transformation methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed problematic DCHECK Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_base.cc ('k') | content/browser/renderer_host/render_widget_host_view_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_mac.h

diff --git a/content/browser/renderer_host/render_widget_host_view_mac.h b/content/browser/renderer_host/render_widget_host_view_mac.h

index 551036b9dcc18a8d657f1f9d65624b9fbdc70c1b..010ecc99e6540205d64a11265d38d390a1f5af2e 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac.h

+++ b/content/browser/renderer_host/render_widget_host_view_mac.h

@@ -344,9 +344,12 @@ class CONTENT_EXPORT RenderWidgetHostViewMac

const ui::LatencyInfo& latency) override;

void ProcessGestureEvent(const blink::WebGestureEvent& event,

const ui::LatencyInfo& latency) override;

- void TransformPointToLocalCoordSpace(const gfx::Point& point,

- const cc::SurfaceId& original_surface,

- gfx::Point* transformed_point) override;

+ gfx::Point TransformPointToLocalCoordSpace(

+ const gfx::Point& point,

+ const cc::SurfaceId& original_surface) override;

+ gfx::Point TransformPointToCoordSpaceForView(

+ const gfx::Point& point,

+ RenderWidgetHostViewBase* target_view) override;

// IPC::Sender implementation.

bool Send(IPC::Message* message) override;