Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1629)

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.cc

Issue 2184033003: Refactor browser process coordinate transformation methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed problematic DCHECK Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_base.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_base.cc b/content/browser/renderer_host/render_widget_host_view_base.cc
index 8b8907e262a95b8790a6b404c8ed0ccef5bc2a1e..d6ad694c328547377ca728f56703de9b9db81855 100644
--- a/content/browser/renderer_host/render_widget_host_view_base.cc
+++ b/content/browser/renderer_host/render_widget_host_view_base.cc
@@ -400,11 +400,17 @@ gfx::PointF RenderWidgetHostViewBase::TransformPointToRootCoordSpaceF(
gfx::ToRoundedPoint(point)));
}
-void RenderWidgetHostViewBase::TransformPointToLocalCoordSpace(
+gfx::Point RenderWidgetHostViewBase::TransformPointToLocalCoordSpace(
const gfx::Point& point,
- const cc::SurfaceId& original_surface,
- gfx::Point* transformed_point) {
- *transformed_point = point;
+ const cc::SurfaceId& original_surface) {
+ return point;
+}
+
+gfx::Point RenderWidgetHostViewBase::TransformPointToCoordSpaceForView(
+ const gfx::Point& point,
+ RenderWidgetHostViewBase* target_view) {
+ NOTREACHED();
+ return point;
}
void RenderWidgetHostViewBase::TextInputStateChanged(

Powered by Google App Engine
This is Rietveld 408576698