Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2178523002: Revert of Add SkRasterPipeline blitter. (Closed)

Created:
4 years, 5 months ago by mtklein
Modified:
4 years, 5 months ago
Reviewers:
mtklein_C, reed1
CC:
msarett, reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add SkRasterPipeline blitter. (patchset #18 id:340001 of https://codereview.chromium.org/2146413002/ ) Reason for revert: Leaking the blitter https://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/7908/steps/test_skia%20on%20Ubuntu/logs/stdio Original issue's description: > Add SkRasterPipeline blitter. > > This is now pixel-exact with the existing sRGB SW impl as far as I've tested. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 > CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot > > Committed: https://skia.googlesource.com/skia/+/3011e337693a9786f62d8de9ac4b239ad6dbdaca TBR=reed@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/aa29b2732914ad65334540babc945ae8c93f9036

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -383 lines) Patch
M gyp/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkColorFilter.h View 3 chunks +0 lines, -5 lines 0 comments Download
M include/core/SkXfermode.h View 4 chunks +3 lines, -7 lines 0 comments Download
M src/core/SkBlitter.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/core/SkColorFilter.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M src/core/SkCoreBlitters.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/core/SkRasterPipeline.h View 2 chunks +2 lines, -6 lines 0 comments Download
M src/core/SkRasterPipeline.cpp View 1 chunk +2 lines, -14 lines 0 comments Download
D src/core/SkRasterPipelineBlitter.cpp View 1 chunk +0 lines, -325 lines 0 comments Download
M src/core/SkXfermode.cpp View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
mtklein
Created Revert of Add SkRasterPipeline blitter.
4 years, 5 months ago (2016-07-22 17:20:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178523002/1
4 years, 5 months ago (2016-07-22 17:20:41 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 17:20:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/aa29b2732914ad65334540babc945ae8c93f9036

Powered by Google App Engine
This is Rietveld 408576698