Componentize spellcheck [2]: move common/ files to component.

Componentize spellcheck [2]: move common/ files to component.

Move chrome/common spellcheck files to component, update
spellcheck namespace, update dependencies and build files,
reformat.

The main motivation behind the componentization of the
spellcheck feature is that we want to make it available
in Android WebView.

Preceding 'componentize' patch:
[1] https://codereview.chromium.org/2166683003/

Note:
Skipping presubmit due to a warning about IPC_ENUM_TRAITS,
which is to be addressed separately.

BUG=583616, 629609
NOPRESUBMIT=true

Committed: https://crrev.com/51b39214e16874c2220dc5f024503fe7ab651920
Cr-Commit-Position: refs/heads/master@{#408442}

[timvolodine, 2016-07-25 19:43:42]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 19:44:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 19:51:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 19:51:22]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[timvolodine, 2016-07-26 15:06:07]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 15:06:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 15:12:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 15:12:45]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[timvolodine, 2016-07-26 17:15:48]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 17:16:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[timvolodine, 2016-07-26 17:18:35]

Description was changed from

==========
Componentize spellcheck [2]: move common/ files to component.

Move chrome/common spellcheck files to component and update
spellcheck namespace.

BUG=583616, 629609
==========

to

==========
Componentize spellcheck [2]: move common/ files to component.

Move chrome/common spellcheck files to component, update
spellcheck namespace, update build files and reformat.

BUG=583616, 629609
==========

[timvolodine, 2016-07-26 17:19:19]

Description was changed from

==========
Componentize spellcheck [2]: move common/ files to component.

Move chrome/common spellcheck files to component, update
spellcheck namespace, update build files and reformat.

BUG=583616, 629609
==========

to

==========
Componentize spellcheck [2]: move common/ files to component.

Move chrome/common spellcheck files to component, update
spellcheck namespace, update dependencies and build files,
reformat.

BUG=583616, 629609
==========

[commit-bot: I haz the power, 2016-07-26 17:22:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 17:22:15]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[timvolodine, 2016-07-26 17:30:57]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 17:31:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 17:37:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 17:37:48]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[timvolodine, 2016-07-26 18:44:47]

The presubmit bot fails because IPC_ENUM_TRAITS in spellcheck_messages.h has
been deprecated. However fixing this is outside the scope of this patch, I am
going to leave it as is for now.

[timvolodine, 2016-07-26 18:46:01]

timvolodine@chromium.org changed reviewers:
+ groby@chromium.org, rouslan@chromium.org, torne@chromium.org

[timvolodine, 2016-07-26 18:46:02]

please take a look

[timvolodine, 2016-07-26 18:48:23]

timvolodine@chromium.org changed reviewers:
+ tsepez@chromium.org

[timvolodine, 2016-07-26 18:48:24]

+tsepez@: for spellcheck_messages.h

[timvolodine, 2016-07-26 18:50:37]

Description was changed from

==========
Componentize spellcheck [2]: move common/ files to component.

Move chrome/common spellcheck files to component, update
spellcheck namespace, update dependencies and build files,
reformat.

BUG=583616, 629609
==========

to

==========
Componentize spellcheck [2]: move common/ files to component.

Move chrome/common spellcheck files to component, update
spellcheck namespace, update dependencies and build files,
reformat.

Preceding 'componentize' patch:
[1] https://codereview.chromium.org/2166683003/

BUG=583616, 629609
==========

[Tom Sepez, 2016-07-26 21:07:47]

messages LGTM

[groby-ooo-7-16, 2016-07-26 21:33:31]

spellcheck RS LGTM % formatting

Can you do a follow  up CL for IPC_ENUM_TRAITS so we don't let this linger for
too long?

https://codereview.chromium.org/2177343002/diff/60001/components/spellcheck/c...
File components/spellcheck/common/spellcheck_common.cc (right):

https://codereview.chromium.org/2177343002/diff/60001/components/spellcheck/c...
components/spellcheck/common/spellcheck_common.cc:32: {"af", "af-ZA"},    
{"bg", "bg-BG"},    {"ca", "ca-ES"},
Please don't reformat this. Even if clang thinks it's a good idea :)

https://codereview.chromium.org/2177343002/diff/60001/components/spellcheck/c...
components/spellcheck/common/spellcheck_common.cc:81: {"tr-TR",
Please don't reformat.

[please use gerrit instead, 2016-07-26 21:38:26]

rouslan@chromium.org changed reviewers:
- rouslan@chromium.org

[blundell, 2016-07-27 08:02:40]

blundell@chromium.org changed reviewers:
+ blundell@chromium.org

[blundell, 2016-07-27 08:02:40]

drive-by nit: Please add the motivation to the CL description ("enable this
feature to be used by Android WebView")

[timvolodine, 2016-07-27 13:55:29]

Description was changed from

==========
Componentize spellcheck [2]: move common/ files to component.

Move chrome/common spellcheck files to component, update
spellcheck namespace, update dependencies and build files,
reformat.

Preceding 'componentize' patch:
[1] https://codereview.chromium.org/2166683003/

BUG=583616, 629609
==========

to

==========
Componentize spellcheck [2]: move common/ files to component.

Move chrome/common spellcheck files to component, update
spellcheck namespace, update dependencies and build files,
reformat.

The main motivation behind componentization of spellcheck
is that we want to make it available in WebView.

Preceding 'componentize' patch:
[1] https://codereview.chromium.org/2166683003/

BUG=583616, 629609
==========

[timvolodine, 2016-07-27 13:56:42]

Description was changed from

==========
Componentize spellcheck [2]: move common/ files to component.

Move chrome/common spellcheck files to component, update
spellcheck namespace, update dependencies and build files,
reformat.

The main motivation behind componentization of spellcheck
is that we want to make it available in WebView.

Preceding 'componentize' patch:
[1] https://codereview.chromium.org/2166683003/

BUG=583616, 629609
==========

to

==========
Componentize spellcheck [2]: move common/ files to component.

Move chrome/common spellcheck files to component, update
spellcheck namespace, update dependencies and build files,
reformat.

The main motivation behind the componentization of the
spellcheck feature is that we want to make it available
in Android WebView.

Preceding 'componentize' patch:
[1] https://codereview.chromium.org/2166683003/

BUG=583616, 629609
==========

[timvolodine, 2016-07-27 13:59:53]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 14:00:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 14:06:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 14:06:07]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[timvolodine, 2016-07-27 14:09:45]

Description was changed from

==========
Componentize spellcheck [2]: move common/ files to component.

Move chrome/common spellcheck files to component, update
spellcheck namespace, update dependencies and build files,
reformat.

The main motivation behind the componentization of the
spellcheck feature is that we want to make it available
in Android WebView.

Preceding 'componentize' patch:
[1] https://codereview.chromium.org/2166683003/

BUG=583616, 629609
==========

to

==========
Componentize spellcheck [2]: move common/ files to component.

Move chrome/common spellcheck files to component, update
spellcheck namespace, update dependencies and build files,
reformat.

The main motivation behind the componentization of the
spellcheck feature is that we want to make it available
in Android WebView.

Preceding 'componentize' patch:
[1] https://codereview.chromium.org/2166683003/

Note:
Skipping presubmit due to a warning about IPC_ENUM_TRAITS,
which is to be addressed separately.

BUG=583616, 629609
NOPRESUBMIT=true
==========

[timvolodine, 2016-07-27 14:10:34]

thanks for the reviews!

groby@:
yes, I'll try to look into IPC_ENUM_TRAITS separately.

blundell@:
updated the description.

https://codereview.chromium.org/2177343002/diff/60001/components/spellcheck/c...
File components/spellcheck/common/spellcheck_common.cc (right):

https://codereview.chromium.org/2177343002/diff/60001/components/spellcheck/c...
components/spellcheck/common/spellcheck_common.cc:32: {"af", "af-ZA"},    
{"bg", "bg-BG"},    {"ca", "ca-ES"},
On 2016/07/26 21:33:31, groby wrote:
> Please don't reformat this. Even if clang thinks it's a good idea :)

Done.

https://codereview.chromium.org/2177343002/diff/60001/components/spellcheck/c...
components/spellcheck/common/spellcheck_common.cc:81: {"tr-TR",
On 2016/07/26 21:33:31, groby wrote:
> Please don't reformat.

Done.

[blundell, 2016-07-27 14:13:21]

Thanks!

[timvolodine, 2016-07-27 14:15:43]

timvolodine@chromium.org changed reviewers:
+ jam@chromium.org

[timvolodine, 2016-07-27 14:15:44]

+jam@: for RS to cover the remaining few chrome/browser and chrome/common bits

[timvolodine, 2016-07-27 14:24:23]

timvolodine@chromium.org changed reviewers:
+ dbeam@chromium.org

[timvolodine, 2016-07-27 14:24:24]

+dbeam@: as owner for
chrome/browser/ui/webui/options/language_options_handler_common.cc

[jam, 2016-07-27 17:40:36]

lgtm with the generator change

https://codereview.chromium.org/2177343002/diff/80001/chrome/common/DEPS
File chrome/common/DEPS (right):

https://codereview.chromium.org/2177343002/diff/80001/chrome/common/DEPS#newc...
chrome/common/DEPS:27: "+components/spellcheck/common",
this shouldn't be needed once the message generator is moved

https://codereview.chromium.org/2177343002/diff/80001/chrome/common/common_me...
File chrome/common/common_message_generator.h (right):

https://codereview.chromium.org/2177343002/diff/80001/chrome/common/common_me...
chrome/common/common_message_generator.h:34: #include
"components/spellcheck/common/spellcheck_messages.h"
the message generator should be in components/spellcheck

[timvolodine, 2016-07-27 18:47:17]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 18:47:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 19:46:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 19:46:52]

Dry run: This issue passed the CQ dry run.

[timvolodine, 2016-07-28 16:52:49]

thanks jam@, addressed the generator comments.

https://codereview.chromium.org/2177343002/diff/80001/chrome/common/DEPS
File chrome/common/DEPS (right):

https://codereview.chromium.org/2177343002/diff/80001/chrome/common/DEPS#newc...
chrome/common/DEPS:27: "+components/spellcheck/common",
On 2016/07/27 17:40:36, jam wrote:
> this shouldn't be needed once the message generator is moved

Done.

https://codereview.chromium.org/2177343002/diff/80001/chrome/common/common_me...
File chrome/common/common_message_generator.h (right):

https://codereview.chromium.org/2177343002/diff/80001/chrome/common/common_me...
chrome/common/common_message_generator.h:34: #include
"components/spellcheck/common/spellcheck_messages.h"
On 2016/07/27 17:40:36, jam wrote:
> the message generator should be in components/spellcheck

Done.

[timvolodine, 2016-07-28 18:14:57]

timvolodine@chromium.org changed reviewers:
+ stevenjb@chromium.org

[timvolodine, 2016-07-28 18:14:58]

stevenjb@ : as owner for
chrome/browser/ui/webui/options/language_options_handler_common.cc

[stevenjb, 2016-07-28 18:20:00]

chrome/browser/ui/webui/options lgtm

[timvolodine, 2016-07-28 18:45:34]

The CQ bit was checked by timvolodine@chromium.org

[timvolodine, 2016-07-28 18:45:34]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
groby@chromium.org, jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2177343002/#ps100001
(title: "move message generator to component")

[commit-bot: I haz the power, 2016-07-28 18:45:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 18:47:32]

Description was changed from

==========
Componentize spellcheck [2]: move common/ files to component.

Move chrome/common spellcheck files to component, update
spellcheck namespace, update dependencies and build files,
reformat.

The main motivation behind the componentization of the
spellcheck feature is that we want to make it available
in Android WebView.

Preceding 'componentize' patch:
[1] https://codereview.chromium.org/2166683003/

Note:
Skipping presubmit due to a warning about IPC_ENUM_TRAITS,
which is to be addressed separately.

BUG=583616, 629609
NOPRESUBMIT=true
==========

to

==========
Componentize spellcheck [2]: move common/ files to component.

Move chrome/common spellcheck files to component, update
spellcheck namespace, update dependencies and build files,
reformat.

The main motivation behind the componentization of the
spellcheck feature is that we want to make it available
in Android WebView.

Preceding 'componentize' patch:
[1] https://codereview.chromium.org/2166683003/

Note:
Skipping presubmit due to a warning about IPC_ENUM_TRAITS,
which is to be addressed separately.

BUG=583616, 629609
NOPRESUBMIT=true
==========

[commit-bot: I haz the power, 2016-07-28 18:47:33]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-07-28 18:48:56]

Description was changed from

==========
Componentize spellcheck [2]: move common/ files to component.

Move chrome/common spellcheck files to component, update
spellcheck namespace, update dependencies and build files,
reformat.

The main motivation behind the componentization of the
spellcheck feature is that we want to make it available
in Android WebView.

Preceding 'componentize' patch:
[1] https://codereview.chromium.org/2166683003/

Note:
Skipping presubmit due to a warning about IPC_ENUM_TRAITS,
which is to be addressed separately.

BUG=583616, 629609
NOPRESUBMIT=true
==========

to

==========
Componentize spellcheck [2]: move common/ files to component.

Move chrome/common spellcheck files to component, update
spellcheck namespace, update dependencies and build files,
reformat.

The main motivation behind the componentization of the
spellcheck feature is that we want to make it available
in Android WebView.

Preceding 'componentize' patch:
[1] https://codereview.chromium.org/2166683003/

Note:
Skipping presubmit due to a warning about IPC_ENUM_TRAITS,
which is to be addressed separately.

BUG=583616, 629609
NOPRESUBMIT=true

Committed: https://crrev.com/51b39214e16874c2220dc5f024503fe7ab651920
Cr-Commit-Position: refs/heads/master@{#408442}
==========

[commit-bot: I haz the power, 2016-07-28 18:48:58]

Patchset 6 (id:??) landed as
https://crrev.com/51b39214e16874c2220dc5f024503fe7ab651920
Cr-Commit-Position: refs/heads/master@{#408442}