chrome/renderer/spellchecker/spellcheck.cc - Issue 2177343002: Componentize spellcheck [2]: move common/ files to component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/spellchecker/spellcheck.cc

Issue 2177343002: Componentize spellcheck [2]: move common/ files to component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move message generator to component Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/spellchecker/platform_spelling_engine.cc ('k') | chrome/renderer/spellchecker/spellcheck_multilingual_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/spellchecker/spellcheck.cc

diff --git a/chrome/renderer/spellchecker/spellcheck.cc b/chrome/renderer/spellchecker/spellcheck.cc

index 8f2bfcba24c6da9f9dbfdabd1e2c640361439e71..d548285588111b220e2e805dc3465a43555951d8 100644

--- a/chrome/renderer/spellchecker/spellcheck.cc

+++ b/chrome/renderer/spellchecker/spellcheck.cc

@@ -19,11 +19,11 @@

#include "base/threading/thread_task_runner_handle.h"

#include "build/build_config.h"

#include "chrome/common/channel_info.h"

-#include "chrome/common/spellcheck_common.h"

-#include "chrome/common/spellcheck_messages.h"

-#include "chrome/common/spellcheck_result.h"

#include "chrome/renderer/spellchecker/spellcheck_language.h"

#include "chrome/renderer/spellchecker/spellcheck_provider.h"

+#include "components/spellcheck/common/spellcheck_common.h"

+#include "components/spellcheck/common/spellcheck_messages.h"

+#include "components/spellcheck/common/spellcheck_result.h"

#include "components/spellcheck/common/spellcheck_switches.h"

#include "content/public/renderer/render_thread.h"

#include "content/public/renderer/render_view.h"

@@ -198,8 +198,7 @@ void SpellCheck::FillSuggestions(

if (!ContainsValue(*optional_suggestions, suggestion)) {

optional_suggestions->push_back(suggestion);

}

- if (optional_suggestions->size() >=

- chrome::spellcheck_common::kMaxSuggestions) {

+ if (optional_suggestions->size() >= spellcheck::kMaxSuggestions) {

break;

}