chrome/browser/spellchecker/spellcheck_service_browsertest.cc - Issue 2177343002: Componentize spellcheck [2]: move common/ files to component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spellcheck_service_browsertest.cc

Issue 2177343002: Componentize spellcheck [2]: move common/ files to component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move message generator to component Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/spellchecker/spellcheck_service.cc ('k') | chrome/browser/spellchecker/spellchecker_session_bridge_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/spellchecker/spellcheck_service_browsertest.cc

diff --git a/chrome/browser/spellchecker/spellcheck_service_browsertest.cc b/chrome/browser/spellchecker/spellcheck_service_browsertest.cc

index d34ab367f7906e756c1607a3dc8c60aa6d2a0aa7..420f26cf21ec14bc1e5cf172e395e13381ff1d96 100644

--- a/chrome/browser/spellchecker/spellcheck_service_browsertest.cc

+++ b/chrome/browser/spellchecker/spellcheck_service_browsertest.cc

@@ -24,10 +24,10 @@

#include "chrome/common/chrome_paths.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/pref_names.h"

-#include "chrome/common/spellcheck_common.h"

-#include "chrome/common/spellcheck_messages.h"

#include "chrome/test/base/in_process_browser_test.h"

#include "components/prefs/pref_service.h"

+#include "components/spellcheck/common/spellcheck_common.h"

+#include "components/spellcheck/common/spellcheck_messages.h"

#include "components/user_prefs/user_prefs.h"

#include "content/public/test/mock_render_process_host.h"

#include "content/public/test/test_utils.h"

@@ -266,7 +266,7 @@ IN_PROC_BROWSER_TEST_F(SpellcheckServiceBrowserTest, DeleteCorruptedBDICT) {

base::FilePath dict_dir;

ASSERT_TRUE(PathService::Get(chrome::DIR_APP_DICTIONARIES, &dict_dir));

base::FilePath bdict_path =

- chrome::spellcheck_common::GetVersionedFileName("en-US", dict_dir);

+ spellcheck::GetVersionedFileName("en-US", dict_dir);

size_t actual = base::WriteFile(bdict_path,

reinterpret_cast<const char*>(kCorruptedBDICT),