chrome/browser/spellchecker/spellcheck_platform_mac.mm - Issue 2177343002: Componentize spellcheck [2]: move common/ files to component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spellcheck_platform_mac.mm

Issue 2177343002: Componentize spellcheck [2]: move common/ files to component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move message generator to component Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/spellchecker/spellcheck_message_filter_unittest.cc ('k') | chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/spellchecker/spellcheck_platform_mac.mm

diff --git a/chrome/browser/spellchecker/spellcheck_platform_mac.mm b/chrome/browser/spellchecker/spellcheck_platform_mac.mm

index a6d5c9f074e7f35ece8380a0895eff91706c3507..668d7e29bdc23ab21b2127d9c819729c0bbae3b8 100644

--- a/chrome/browser/spellchecker/spellcheck_platform_mac.mm

+++ b/chrome/browser/spellchecker/spellcheck_platform_mac.mm

@@ -14,8 +14,8 @@

#include "base/mac/foundation_util.h"

#include "base/strings/sys_string_conversions.h"

#include "base/time/time.h"

-#include "chrome/common/spellcheck_common.h"

-#include "chrome/common/spellcheck_result.h"

+#include "components/spellcheck/common/spellcheck_common.h"

+#include "components/spellcheck/common/spellcheck_result.h"

#include "content/public/browser/browser_message_filter.h"

#include "content/public/browser/browser_thread.h"

@@ -209,7 +209,7 @@ void FillSuggestionList(const base::string16& wrong_word,

int i = 0;

for (NSString* guess in guesses) {

optional_suggestions->push_back(base::SysNSStringToUTF16(guess));

- if (++i >= chrome::spellcheck_common::kMaxSuggestions)

+ if (++i >= spellcheck::kMaxSuggestions)

break;

}