chrome/browser/sync/test/integration/performance/dictionary_sync_perf_test.cc - Issue 2177343002: Componentize spellcheck [2]: move common/ files to component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/performance/dictionary_sync_perf_test.cc

Issue 2177343002: Componentize spellcheck [2]: move common/ files to component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move message generator to component Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/spellchecker/spelling_service_client_unittest.cc ('k') | chrome/browser/sync/test/integration/two_client_dictionary_sync_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/performance/dictionary_sync_perf_test.cc

diff --git a/chrome/browser/sync/test/integration/performance/dictionary_sync_perf_test.cc b/chrome/browser/sync/test/integration/performance/dictionary_sync_perf_test.cc

index 2d18a8b258eabc5f4d825608d791d581f0be1c0c..848767c9fc1585338d0ce8c6f72311c09f0362ea 100644

--- a/chrome/browser/sync/test/integration/performance/dictionary_sync_perf_test.cc

+++ b/chrome/browser/sync/test/integration/performance/dictionary_sync_perf_test.cc

@@ -10,7 +10,7 @@

#include "chrome/browser/sync/test/integration/performance/sync_timing_helper.h"

#include "chrome/browser/sync/test/integration/profile_sync_service_harness.h"

#include "chrome/browser/sync/test/integration/sync_test.h"

-#include "chrome/common/spellcheck_common.h"

+#include "components/spellcheck/common/spellcheck_common.h"

class DictionarySyncPerfTest : public SyncTest {

public:

@@ -27,20 +27,16 @@ IN_PROC_BROWSER_TEST_F(DictionarySyncPerfTest, P0) {

ASSERT_TRUE(dictionary_helper::DictionariesMatch());

base::TimeDelta dt;

- for (size_t i = 0;

- i < chrome::spellcheck_common::MAX_SYNCABLE_DICTIONARY_WORDS;

- ++i) {

+ for (size_t i = 0; i < spellcheck::MAX_SYNCABLE_DICTIONARY_WORDS; ++i) {

ASSERT_TRUE(dictionary_helper::AddWord(

0, "foo" + base::Uint64ToString(i)));

}

dt = SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));

- ASSERT_EQ(chrome::spellcheck_common::MAX_SYNCABLE_DICTIONARY_WORDS,

+ ASSERT_EQ(spellcheck::MAX_SYNCABLE_DICTIONARY_WORDS,

dictionary_helper::GetDictionarySize(1));

SyncTimingHelper::PrintResult("dictionary", "add_words", dt);

- for (size_t i = 0;

- i < chrome::spellcheck_common::MAX_SYNCABLE_DICTIONARY_WORDS;

- ++i) {

+ for (size_t i = 0; i < spellcheck::MAX_SYNCABLE_DICTIONARY_WORDS; ++i) {

ASSERT_TRUE(dictionary_helper::RemoveWord(

0, "foo" + base::Uint64ToString(i)));

}