Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2176323002: Deprecate FLAGS_quic_disable_pre_30. Remove QUIC versions [25-29]. (Closed)

Created:
4 years, 5 months ago by Ryan Hamilton
Modified:
4 years, 4 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@127879468
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate FLAGS_quic_disable_pre_30. Remove QUIC versions [25-29]. Merge internal change: 128058105 BUG=

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -354 lines) Patch
M net/quic/crypto/crypto_server_test.cc View 5 chunks +4 lines, -15 lines 0 comments Download
M net/quic/crypto/proof_verifier_chromium_test.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config.cc View 6 chunks +12 lines, -23 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config_test.cc View 1 chunk +2 lines, -27 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 8 chunks +49 lines, -61 lines 0 comments Download
M net/quic/quic_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_connection_test.cc View 5 chunks +9 lines, -36 lines 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 4 chunks +2 lines, -5 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_framer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_protocol.h View 2 chunks +1 line, -8 lines 0 comments Download
M net/quic/quic_protocol.cc View 3 chunks +7 lines, -27 lines 0 comments Download
M net/quic/quic_protocol_test.cc View 4 chunks +20 lines, -14 lines 0 comments Download
M net/quic/quic_server_session_base_test.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M net/quic/quic_session.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M net/quic/quic_session_test.cc View 3 chunks +5 lines, -18 lines 0 comments Download
M net/quic/quic_spdy_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_spdy_stream.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M net/quic/quic_spdy_stream_test.cc View 1 chunk +1 line, -8 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 6 chunks +13 lines, -49 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 1 chunk +2 lines, -4 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 2 chunks +1 line, -3 lines 2 comments Download
M net/tools/quic/quic_simple_server_stream_test.cc View 2 chunks +2 lines, -10 lines 0 comments Download

Depends on Patchset:

Issue 2176193003 Patch 1

Dependent Patchsets:

Issue 2175423003 Patch 1

Messages

Total messages: 4 (1 generated)
Ryan Hamilton
4 years, 5 months ago (2016-07-25 22:14:30 UTC) #2
Zhongyi Shi
lgtm https://codereview.chromium.org/2176323002/diff/1/net/tools/quic/quic_dispatcher.cc File net/tools/quic/quic_dispatcher.cc (right): https://codereview.chromium.org/2176323002/diff/1/net/tools/quic/quic_dispatcher.cc#newcode747 net/tools/quic/quic_dispatcher.cc:747: } nit: though this looks consistent with the ...
4 years, 5 months ago (2016-07-25 22:52:50 UTC) #3
Ryan Hamilton
4 years, 5 months ago (2016-07-25 23:07:34 UTC) #4 
https://codereview.chromium.org/2176323002/diff/1/net/tools/quic/quic_dispatc...
File net/tools/quic/quic_dispatcher.cc (right):

https://codereview.chromium.org/2176323002/diff/1/net/tools/quic/quic_dispatc...
net/tools/quic/quic_dispatcher.cc:747: }
On 2016/07/25 22:52:49, Zhongyi Shi wrote:
> nit: though this looks consistent with the internal CL. But out of curiosity,
> why do we have this chunk of code left here?

'cause this code is going to come back RSN with v35 and v36. (Fan is working on
this). But yeah. This is warty.

Powered by Google App Engine
This is Rietveld 408576698