Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: net/quic/crypto/quic_crypto_client_config_test.cc

Issue 2176323002: Deprecate FLAGS_quic_disable_pre_30. Remove QUIC versions [25-29]. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@127879468
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/crypto/quic_crypto_client_config_test.cc
diff --git a/net/quic/crypto/quic_crypto_client_config_test.cc b/net/quic/crypto/quic_crypto_client_config_test.cc
index 8fb6e05840ef91f480148b0d310021457c8df461..0f6a96f9c67440311fbcc9f824004a2d705a7a96 100644
--- a/net/quic/crypto/quic_crypto_client_config_test.cc
+++ b/net/quic/crypto/quic_crypto_client_config_test.cc
@@ -432,39 +432,14 @@ TEST(QuicCryptoClientConfigTest, BadlyFormattedStatelessReject) {
EXPECT_EQ("Missing kRCID", error);
}
-TEST(QuicCryptoClientConfigTest, ServerNonceinSHLO_BeforeQ027) {
- // Test that in QUIC_VERSION_26 and lower, the the server does not need to
- // include a nonce in the SHLO.
- CryptoHandshakeMessage msg;
- msg.set_tag(kSHLO);
- // Choose the lowest version.
- QuicVersionVector supported_versions;
- QuicVersion version = QuicSupportedVersions().back();
- supported_versions.push_back(version);
- EXPECT_LE(version, QUIC_VERSION_26);
- QuicTagVector versions;
- versions.push_back(QuicVersionToQuicTag(version));
- msg.SetVector(kVER, versions);
-
- QuicCryptoClientConfig config(CryptoTestUtils::ProofVerifierForTesting());
- QuicCryptoClientConfig::CachedState cached;
- QuicCryptoNegotiatedParameters out_params;
- string error_details;
- config.ProcessServerHello(msg, 0, version, supported_versions, &cached,
- &out_params, &error_details);
- EXPECT_NE("server hello missing server nonce", error_details);
-}
-
-TEST(QuicCryptoClientConfigTest, ServerNonceinSHLO_AfterQ027) {
- // Test that in QUIC_VERSION_27 and higher, the the server must include a
- // nonce in the SHLO.
+TEST(QuicCryptoClientConfigTest, ServerNonceinSHLO) {
+ // Test that the server must include a nonce in the SHLO.
CryptoHandshakeMessage msg;
msg.set_tag(kSHLO);
// Choose the latest version.
QuicVersionVector supported_versions;
QuicVersion version = QuicSupportedVersions().front();
supported_versions.push_back(version);
- EXPECT_LE(QUIC_VERSION_27, version);
QuicTagVector versions;
versions.push_back(QuicVersionToQuicTag(version));
msg.SetVector(kVER, versions);

Powered by Google App Engine
This is Rietveld 408576698