Issue 2175423003: not sending kFIXD in QUIC handshake. behind FLAGS_quic_deprecate_kfixd

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2175423003: not sending kFIXD in QUIC handshake. behind FLAGS_quic_deprecate_kfixd (Closed)

Created:
4 years, 5 months ago by Ryan Hamilton

Modified:
4 years, 4 months ago

Reviewers:
Zhongyi Shi

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@128058105

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

not sending kFIXD in QUIC handshake. behind FLAGS_quic_deprecate_kfixd Merge internal change: 128087239 BUG=

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	net/quic/quic_crypto_client_stream.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Depends on Patchset:

Dependent Patchsets:

Total messages: 5 (2 generated)

Zhongyi Shi

4 years, 4 months ago (2016-07-26 05:53:12 UTC) #4

On 2016/07/25 22:55:08, Zhongyi Shi wrote:
> lgtm

You might also need to remove internal info from the issue description, and also
in the final :)