Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: net/quic/quic_session_test.cc

Issue 2176323002: Deprecate FLAGS_quic_disable_pre_30. Remove QUIC versions [25-29]. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@127879468
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_session_test.cc
diff --git a/net/quic/quic_session_test.cc b/net/quic/quic_session_test.cc
index d37b42f6c96926ba367ae2cdd0625c68175d3bb1..7ff33d12c27380666087a31bba926944e5e13ba4 100644
--- a/net/quic/quic_session_test.cc
+++ b/net/quic/quic_session_test.cc
@@ -1041,8 +1041,7 @@ TEST_P(QuicSessionTestServer, WindowUpdateUnblocksHeadersStream) {
TEST_P(QuicSessionTestServer, TooManyUnfinishedStreamsCauseServerRejectStream) {
// If a buggy/malicious peer creates too many streams that are not ended
- // with a FIN or RST then we send a connection close or an RST to
- // refuse streams.
+ // with a FIN or RST then we send an RST to refuse streams.
const QuicStreamId kMaxStreams = 5;
QuicSessionPeer::SetMaxOpenIncomingStreams(&session_, kMaxStreams);
const QuicStreamId kFirstStreamId = kClientDataStreamId1;
@@ -1058,15 +1057,9 @@ TEST_P(QuicSessionTestServer, TooManyUnfinishedStreamsCauseServerRejectStream) {
session_.CloseStream(i);
}
- if (GetParam() <= QUIC_VERSION_27) {
- EXPECT_CALL(*connection_,
- CloseConnection(QUIC_TOO_MANY_OPEN_STREAMS, _, _));
- EXPECT_CALL(*connection_, SendRstStream(kFinalStreamId, _, _)).Times(0);
- } else {
- EXPECT_CALL(*connection_,
- SendRstStream(kFinalStreamId, QUIC_REFUSED_STREAM, _))
- .Times(1);
- }
+ EXPECT_CALL(*connection_,
+ SendRstStream(kFinalStreamId, QUIC_REFUSED_STREAM, _))
+ .Times(1);
// Create one more data streams to exceed limit of open stream.
QuicStreamFrame data1(kFinalStreamId, false, 0, StringPiece("HT"));
session_.OnStreamFrame(data1);
@@ -1080,13 +1073,7 @@ TEST_P(QuicSessionTestServer, DrainingStreamsDoNotCountAsOpened) {
// Verify that a draining stream (which has received a FIN but not consumed
// it) does not count against the open quota (because it is closed from the
// protocol point of view).
- if (GetParam() <= QUIC_VERSION_27) {
- EXPECT_CALL(*connection_, CloseConnection(QUIC_TOO_MANY_OPEN_STREAMS, _, _))
- .Times(0);
- } else {
- EXPECT_CALL(*connection_, SendRstStream(_, QUIC_REFUSED_STREAM, _))
- .Times(0);
- }
+ EXPECT_CALL(*connection_, SendRstStream(_, QUIC_REFUSED_STREAM, _)).Times(0);
const QuicStreamId kMaxStreams = 5;
QuicSessionPeer::SetMaxOpenIncomingStreams(&session_, kMaxStreams);

Powered by Google App Engine
This is Rietveld 408576698