Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: net/quic/quic_protocol.cc

Issue 2176323002: Deprecate FLAGS_quic_disable_pre_30. Remove QUIC versions [25-29]. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@127879468
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_protocol.cc
diff --git a/net/quic/quic_protocol.cc b/net/quic/quic_protocol.cc
index fe387f08a4f361fa70ad3f940ab26a2f8d71cb6e..03920e21342b1f88f08b376d074c0234f6808947 100644
--- a/net/quic/quic_protocol.cc
+++ b/net/quic/quic_protocol.cc
@@ -183,22 +183,17 @@ QuicVersionVector FilterSupportedVersions(QuicVersionVector versions) {
QuicVersionVector filtered_versions(versions.size());
filtered_versions.clear(); // Guaranteed by spec not to change capacity.
for (QuicVersion version : versions) {
- if (version < QUIC_VERSION_30) {
- if (!FLAGS_quic_disable_pre_30) {
+ if (version == QUIC_VERSION_35) {
+ if (FLAGS_quic_enable_version_35) {
filtered_versions.push_back(version);
}
- } else {
- if (version == QUIC_VERSION_35) {
- if (FLAGS_quic_enable_version_35) {
- filtered_versions.push_back(version);
- }
- } else if (version == QUIC_VERSION_36) {
- if (FLAGS_quic_enable_version_35 && FLAGS_quic_enable_version_36) {
- filtered_versions.push_back(version);
- }
- } else {
+ } else if (version == QUIC_VERSION_36) {
+ if (FLAGS_quic_enable_version_35 &&
+ FLAGS_quic_enable_version_36) {
filtered_versions.push_back(version);
}
+ } else {
+ filtered_versions.push_back(version);
}
}
return filtered_versions;
@@ -206,16 +201,6 @@ QuicVersionVector FilterSupportedVersions(QuicVersionVector versions) {
QuicTag QuicVersionToQuicTag(const QuicVersion version) {
switch (version) {
- case QUIC_VERSION_25:
- return MakeQuicTag('Q', '0', '2', '5');
- case QUIC_VERSION_26:
- return MakeQuicTag('Q', '0', '2', '6');
- case QUIC_VERSION_27:
- return MakeQuicTag('Q', '0', '2', '7');
- case QUIC_VERSION_28:
- return MakeQuicTag('Q', '0', '2', '8');
- case QUIC_VERSION_29:
- return MakeQuicTag('Q', '0', '2', '9');
case QUIC_VERSION_30:
return MakeQuicTag('Q', '0', '3', '0');
case QUIC_VERSION_31:
@@ -256,11 +241,6 @@ QuicVersion QuicTagToQuicVersion(const QuicTag version_tag) {
string QuicVersionToString(const QuicVersion version) {
switch (version) {
- RETURN_STRING_LITERAL(QUIC_VERSION_25);
- RETURN_STRING_LITERAL(QUIC_VERSION_26);
- RETURN_STRING_LITERAL(QUIC_VERSION_27);
- RETURN_STRING_LITERAL(QUIC_VERSION_28);
- RETURN_STRING_LITERAL(QUIC_VERSION_29);
RETURN_STRING_LITERAL(QUIC_VERSION_30);
RETURN_STRING_LITERAL(QUIC_VERSION_31);
RETURN_STRING_LITERAL(QUIC_VERSION_32);

Powered by Google App Engine
This is Rietveld 408576698